New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: support node:
protocol when building Playground
#565
Conversation
✅ Deploy Preview for ja-eslint ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for es-eslint ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for new-eslint ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for hi-eslint ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for pt-br-eslint ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for fr-eslint ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
src/playground/package.json
Outdated
"eslint": "latest" | ||
"eslint": "github:eslint/eslint" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is to test Playground with an ESLint version that uses the node:
protocol. When it's verified that the Playground works well, I'll revert this change.
✅ Deploy Preview for de-eslint ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for zh-hans-eslint ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
@mdjermanovic this is marked as a draft. Is it ready for review? |
Yes, it's ready for review and for testing the Playground in the deploy preview. I just marked it as a draft because the package.json change needs to be reverted before merging. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Tested it out in the deploy preview and everything appears to work correctly.
Prerequisites checklist
What is the purpose of this pull request?
Updates webpack config to support
node:
protocol (e.g.,require("node:path")
).This change is necessary in order to build the Playground from the upcoming ESLint v9.3.0 because it will use the
node:
protocol.What changes did you make? (Give an overview)
Updated webpack config like in eslint/eslint#18434, as recommended in webpack/webpack#13290.
Related Issues
eslint/eslint#18434
Is there anything you'd like reviewers to focus on?
Check that the playground is working properly in the deploy preview.