fix: false negative with onlyDeclarations in id-match

Fixes #15123
eslint · Dec 16, 2021 · 10215e6 · 10215e6
1 parent 981fb48
commit 10215e6
Show file tree

Hide file tree

Showing 2 changed files with 33 additions and 1 deletion.
diff --git a/lib/rules/id-match.js b/lib/rules/id-match.js
@@ -238,6 +238,13 @@ module.exports = {
                         }
                     }
 
+                    // For https://github.com/eslint/eslint/issues/15123
+                    if (parent.parent && parent.parent.type === "ObjectExpression") {
+                        if (checkProperties && parent.key === node && isInvalid(name)) {
+                            report(node);
+                        }
+                    }
+
                     // never check properties or always ignore destructuring
                     if (!checkProperties || (ignoreDestructuring && isInsideObjectPattern(node))) {
                         return;

diff --git a/tests/lib/rules/id-match.js b/tests/lib/rules/id-match.js
@@ -774,7 +774,32 @@ ruleTester.run("id-match", rule, {
                     type: "PrivateIdentifier"
                 }
             ]
-        }
+        },
 
+        // https://github.com/eslint/eslint/issues/15123
+        {
+            code: `
+            const foo = {
+                foo_one: 1,
+                bar_one: 2,
+                fooBar: 3
+            };
+            `,
+            options: ["^[^_]+$", {
+                properties: true,
+                onlyDeclarations: true
+            }],
+            parserOptions: { ecmaVersion: 2022 },
+            errors: [
+                {
+                    message: "Identifier 'foo_one' does not match the pattern '^[^_]+$'.",
+                    type: "Identifier"
+                },
+                {
+                    message: "Identifier 'bar_one' does not match the pattern '^[^_]+$'.",
+                    type: "Identifier"
+                }
+            ]
+        }
     ]
 });