Fix: no-constant-condition false positives with unary expressions (#1…

…3927)
eslint · Dec 18, 2020 · 301d0c0 · 301d0c0
1 parent 555c128
commit 301d0c0
Show file tree

Hide file tree

Showing 2 changed files with 22 additions and 3 deletions.
diff --git a/lib/rules/no-constant-condition.js b/lib/rules/no-constant-condition.js
@@ -147,12 +147,18 @@ module.exports = {
                 }
 
                 case "UnaryExpression":
-                    if (node.operator === "void") {
+                    if (
+                        node.operator === "void" ||
+                        node.operator === "typeof" && inBooleanPosition
+                    ) {
                         return true;
                     }
 
-                    return (node.operator === "typeof" && inBooleanPosition) ||
-                        isConstant(node.argument, true);
+                    if (node.operator === "!") {
+                        return isConstant(node.argument, true);
+                    }
+
+                    return isConstant(node.argument, false);
 
                 case "BinaryExpression":
                     return isConstant(node.left, false) &&

diff --git a/tests/lib/rules/no-constant-condition.js b/tests/lib/rules/no-constant-condition.js
@@ -32,6 +32,10 @@ ruleTester.run("no-constant-condition", rule, {
         "if (`foo${a}` === 'fooa');",
         "if (tag`a`);",
         "if (tag`${a}`);",
+        "if (+(a || true));",
+        "if (-(a || true));",
+        "if (~(a || 1));",
+        "if (+(a && 0) === +(b && 0));",
         "while(~!a);",
         "while(a = b);",
         "while(`${a}`);",
@@ -162,6 +166,15 @@ ruleTester.run("no-constant-condition", rule, {
         { code: "if(`foo${0 || 1}`);", errors: [{ messageId: "unexpected", type: "TemplateLiteral" }] },
         { code: "if(`foo${bar}`);", errors: [{ messageId: "unexpected", type: "TemplateLiteral" }] },
         { code: "if(`${bar}foo`);", errors: [{ messageId: "unexpected", type: "TemplateLiteral" }] },
+        { code: "if(!(true || a));", errors: [{ messageId: "unexpected", type: "UnaryExpression" }] },
+        { code: "if(!(a && void b && c));", errors: [{ messageId: "unexpected", type: "UnaryExpression" }] },
+        { code: "if(0 || !(a && null));", errors: [{ messageId: "unexpected", type: "LogicalExpression" }] },
+        { code: "if(1 + !(a || true));", errors: [{ messageId: "unexpected", type: "BinaryExpression" }] },
+        { code: "if(!(null && a) > 1);", errors: [{ messageId: "unexpected", type: "BinaryExpression" }] },
+        { code: "if(+(!(a && 0)));", errors: [{ messageId: "unexpected", type: "UnaryExpression" }] },
+        { code: "if(!typeof a === 'string');", errors: [{ messageId: "unexpected", type: "BinaryExpression" }] },
+        { code: "if(-('foo' || a));", errors: [{ messageId: "unexpected", type: "UnaryExpression" }] },
+        { code: "if(+(void a && b) === ~(1 || c));", errors: [{ messageId: "unexpected", type: "BinaryExpression" }] },
 
 
         { code: "while([]);", errors: [{ messageId: "unexpected", type: "ArrayExpression" }] },