Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Merge branch 'master' into ignore-patterns
- Loading branch information
Showing
49 changed files
with
12,821 additions
and
126 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,44 @@ | ||
| # disallow assigning to imported bindings (no-import-assign) | ||
|
|
||
| The updates of imported bindings by ES Modules cause runtime errors. | ||
|
|
||
| ## Rule Details | ||
|
|
||
| This rule warns the assignments, increments, and decrements of imported bindings. | ||
|
|
||
| Examples of **incorrect** code for this rule: | ||
|
|
||
| ```js | ||
| /*eslint no-import-assign: "error"*/ | ||
|
|
||
| import mod, { named } from "./mod.mjs" | ||
| import * as mod_ns from "./mod.mjs" | ||
|
|
||
| mod = 1 // ERROR: 'mod' is readonly. | ||
| named = 2 // ERROR: 'named' is readonly. | ||
| mod_ns.named = 3 // ERROR: the members of 'mod_ns' is readonly. | ||
| mod_ns = {} // ERROR: 'mod_ns' is readonly. | ||
| ``` | ||
|
|
||
| Examples of **correct** code for this rule: | ||
|
|
||
| ```js | ||
| /*eslint no-import-assign: "error"*/ | ||
|
|
||
| import mod, { named } from "./mod.mjs" | ||
| import * as mod_ns from "./mod.mjs" | ||
|
|
||
| mod.prop = 1 | ||
| named.prop = 2 | ||
| mod_ns.named.prop = 3 | ||
|
|
||
| // Known Limitation | ||
| function test(obj) { | ||
| obj.named = 4 // Not errored because 'obj' is not namespace objects. | ||
| } | ||
| test(mod_ns) // Not errored because it doesn't know that 'test' updates the member of the argument. | ||
| ``` | ||
|
|
||
| ## When Not To Use It | ||
|
|
||
| If you don't want to be notified about modifying imported bindings, you can disable this rule. |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.