Skip to content

Commit

Permalink
Upgrade: levn@0.4.1 (fixes #9366)
Browse files Browse the repository at this point in the history
  • Loading branch information
kaicataldo committed Apr 4, 2020
1 parent a784dac commit 420a983
Show file tree
Hide file tree
Showing 2 changed files with 20 additions and 3 deletions.
2 changes: 1 addition & 1 deletion package.json
Expand Up @@ -69,7 +69,7 @@
"is-glob": "^4.0.0",
"js-yaml": "^3.13.1",
"json-stable-stringify-without-jsonify": "^1.0.1",
"levn": "^0.3.0",
"levn": "^0.4.1",
"lodash": "^4.17.14",
"minimatch": "^3.0.4",
"natural-compare": "^1.4.0",
Expand Down
21 changes: 19 additions & 2 deletions tests/lib/linter/linter.js
Expand Up @@ -2733,14 +2733,31 @@ describe("Linter", () => {
});

describe("when evaluating code with comments which have colon in its value", () => {
const code = "/* eslint max-len: [2, 100, 2, {ignoreUrls: true, ignorePattern: \"data:image\\/|\\s*require\\s*\\(|^\\s*loader\\.lazy|-\\*-\"}] */\nalert('test');";
const code = "/* eslint max-len: [2, 100, 2, {ignoreUrls: true, ignorePattern: \"data:image\\/|\\\\s*require\\\\s*\\\\(|^\\\\s*loader\\\\.lazy|-\\\\*-\"}] */\nalert('test');";

it("should not parse errors, should report a violation", () => {
const messages = linter.verify(code, {}, filename);

assert.strictEqual(messages.length, 1);
assert.strictEqual(messages[0].ruleId, "max-len");
assert.strictEqual(messages[0].message, "This line has a length of 122. Maximum allowed is 100.");
assert.strictEqual(messages[0].message, "This line has a length of 128. Maximum allowed is 100.");
assert.include(messages[0].nodeType, "Program");
});
});

describe("when evaluating code with comments that contain escape sequences", () => {
const code = '/* eslint max-len: ["error", 1, { ignoreComments: true, ignorePattern: "console\\.log\\\\(" }] */\nconsole.log("test");\nvar a = "test2";';

it("should validate correctly", () => {
const config = { rules: {} };

const messages = linter.verify(code, config, filename);

assert.strictEqual(messages.length, 1);
assert.strictEqual(messages[0].ruleId, "max-len");
assert.strictEqual(messages[0].message, "This line has a length of 16. Maximum allowed is 1.");
assert.strictEqual(messages[0].line, 3);
assert.strictEqual(messages[0].column, 1);
assert.include(messages[0].nodeType, "Program");
});
});
Expand Down

0 comments on commit 420a983

Please sign in to comment.