Revert "Fix: Replace Infinity with Number.MAX_SAFE_INTEGER (fixes #13427

) (#13435)" This reverts commit de77c11.
eslint · Jun 30, 2020 · 4e679b1 · 4e679b1
1 parent 5c4c3fd
commit 4e679b1
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 22 deletions.
diff --git a/lib/cli-engine/config-array-factory.js b/lib/cli-engine/config-array-factory.js
@@ -722,12 +722,7 @@ class ConfigArrayFactory {
          *
          * Refer https://github.com/eslint/eslint/issues/12592
          */
-        const clonedRulesConfig = rules && JSON.parse(
-            JSON.stringify(
-                rules,
-                (key, value) => (value === Infinity ? Number.MAX_SAFE_INTEGER : value)
-            )
-        );
+        const clonedRulesConfig = rules && JSON.parse(JSON.stringify((rules)));
 
         // Flatten `extends`.
         for (const extendName of extendList.filter(Boolean)) {

diff --git a/tests/fixtures/config-file/cloned-config/configWithInfinity.js b/tests/fixtures/config-file/cloned-config/configWithInfinity.js
diff --git a/tests/lib/cli.js b/tests/lib/cli.js
@@ -1172,7 +1172,9 @@ describe("cli", () => {
 
                 assert.strictEqual(exit, 0);
             });
+        });
 
+        describe("config file and input file", () => {
             it("should exit with 1 as camelcase has wrong property type", async () => {
                 const configPath = getFixturePath("config-file", "cloned-config", "eslintConfigFail.js");
                 const filePath = getFixturePath("config-file", "cloned-config", "index.js");
@@ -1185,16 +1187,6 @@ describe("cli", () => {
                 }
 
             });
-
-            it("should not cause an error when a rule configuration has `Infinity`", async () => {
-                const configPath = getFixturePath("config-file", "cloned-config", "configWithInfinity.js");
-                const filePath = getFixturePath("config-file", "cloned-config", "index.js");
-                const args = `--config ${configPath} ${filePath}`;
-
-                const exit = await cli.execute(args);
-
-                assert.strictEqual(exit, 0);
-            });
         });
 
         describe("inline config and input file", () => {