Fix: no check for shadowed Object (fixes #12809) (#13115)

eslint · Apr 1, 2020 · 7551f0c · 7551f0c
1 parent 988d842
commit 7551f0c
Show file tree

Hide file tree

Showing 3 changed files with 59 additions and 9 deletions.
diff --git a/docs/rules/no-new-object.md b/docs/rules/no-new-object.md
@@ -27,7 +27,7 @@ Examples of **incorrect** code for this rule:
 
 var myObject = new Object();
 
-var myObject = new Object;
+new Object();
 ```
 
 Examples of **correct** code for this rule:
@@ -38,6 +38,9 @@ Examples of **correct** code for this rule:
 var myObject = new CustomObject();
 
 var myObject = {};
+
+var Object = function Object() {};
+new Object();
 ```
 
 ## When Not To Use It

diff --git a/lib/rules/no-new-object.js b/lib/rules/no-new-object.js
@@ -5,6 +5,12 @@
 
 "use strict";
 
+//------------------------------------------------------------------------------
+// Requirements
+//------------------------------------------------------------------------------
+
+const astUtils = require("./utils/ast-utils");
+
 //------------------------------------------------------------------------------
 // Rule Definition
 //------------------------------------------------------------------------------
@@ -28,10 +34,17 @@ module.exports = {
     },
 
     create(context) {
-
         return {
-
             NewExpression(node) {
+                const variable = astUtils.getVariableByName(
+                    context.getScope(),
+                    node.callee.name
+                );
+
+                if (variable && variable.identifiers.length > 0) {
+                    return;
+                }
+
                 if (node.callee.name === "Object") {
                     context.report({
                         node,
@@ -40,6 +53,5 @@ module.exports = {
                 }
             }
         };
-
     }
 };
diff --git a/tests/lib/rules/no-new-object.js b/tests/lib/rules/no-new-object.js
@@ -20,15 +20,50 @@ const ruleTester = new RuleTester();
 
 ruleTester.run("no-new-object", rule, {
     valid: [
-        "var foo = new foo.Object()"
+        "var myObject = {};",
+        "var myObject = new CustomObject();",
+        "var foo = new foo.Object()",
+        `var Object = function Object() {};
+            new Object();`,
+        `var x = something ? MyClass : Object;
+        var y = new x();`,
+        {
+            code: `
+        class Object {
+            constructor(){
+
+            }
+        }
+        new Object();
+        `,
+            parserOptions: { ecmaVersion: 6 }
+        },
+        {
+            code: `
+        import { Object } from './'
+        new Object();
+        `,
+            parserOptions: { ecmaVersion: 6, sourceType: "module" }
+        }
     ],
     invalid: [
         {
             code: "var foo = new Object()",
-            errors: [{
-                messageId: "preferLiteral",
-                type: "NewExpression"
-            }]
+            errors: [
+                {
+                    messageId: "preferLiteral",
+                    type: "NewExpression"
+                }
+            ]
+        },
+        {
+            code: "new Object();",
+            errors: [{ messageId: "preferLiteral", type: "NewExpression" }]
+        },
+        {
+            code: "const a = new Object()",
+            parserOptions: { ecmaVersion: 6 },
+            errors: [{ messageId: "preferLiteral", type: "NewExpression" }]
         }
     ]
 });