Chore: Handle sequence expression in radix suggestion

eslint · Apr 29, 2021 · 933e735 · 933e735
1 parent 4f9fd94
commit 933e735
Show file tree

Hide file tree

Showing 2 changed files with 22 additions and 2 deletions.
diff --git a/lib/rules/radix.js b/lib/rules/radix.js
@@ -131,9 +131,12 @@ module.exports = {
                                     messageId: "addRadixParameter10",
                                     fix(fixer) {
                                         const sourceCode = context.getSourceCode();
-                                        const argText = sourceCode.getText(node.arguments[0]);
+                                        const tokens = sourceCode.getTokens(node);
+                                        const lastToken = tokens[tokens.length - 1]; // Parenthesis.
+                                        const secondToLastToken = tokens[tokens.length - 2]; // May or may not be a comma.
+                                        const hasTrailingComma = secondToLastToken.type === "Punctuator" && secondToLastToken.value === ",";
 
-                                        return fixer.replaceText(node.arguments[0], `${argText}, 10`);
+                                        return fixer.insertTextBefore(lastToken, hasTrailingComma ? " 10," : ", 10");
                                     }
                                 }
                             ]

diff --git a/tests/lib/rules/radix.js b/tests/lib/rules/radix.js
@@ -89,6 +89,23 @@ ruleTester.run("radix", rule, {
                 suggestions: [{ messageId: "addRadixParameter10", output: "parseInt(\"10\", 10,);" }]
             }]
         },
+        {
+            code: "parseInt((0, \"10\"));", // Sequence expression (no trailing comma).
+            errors: [{
+                messageId: "missingRadix",
+                type: "CallExpression",
+                suggestions: [{ messageId: "addRadixParameter10", output: "parseInt((0, \"10\"), 10);" }]
+            }]
+        },
+        {
+            code: "parseInt((0, \"10\"),);", // Sequence expression (with trailing comma).
+            parserOptions: { ecmaVersion: 2017 },
+            errors: [{
+                messageId: "missingRadix",
+                type: "CallExpression",
+                suggestions: [{ messageId: "addRadixParameter10", output: "parseInt((0, \"10\"), 10,);" }]
+            }]
+        },
         {
             code: "parseInt(\"10\", null);",
             errors: [{