Skip to content

Commit

Permalink
chore: udpate comment
Browse files Browse the repository at this point in the history
  • Loading branch information
@snitin315
snitin315 committed Dec 3, 2021
1 parent c3ac824 commit e14c304
Show file tree
Hide file tree
Showing 2 changed files with 17 additions and 19 deletions.
4 changes: 1 addition & 3 deletions lib/rules/prefer-object-has-own.js
View file
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,7 @@ module.exports = {
const objectPropertyName = astUtils.getStaticPropertyName(node.callee.object);
const isObject = checkForObject(node.callee);

// check `Object`
// check `Object` scope
const scope = context.getScope();
const variable = astUtils.getVariableByName(scope, "Object");

Expand All @@ -80,8 +80,6 @@ module.exports = {
messageId: "useHasOwn",
*fix(fixer) {
yield fixer.replaceText(node.callee, "Object.hasOwn");

yield fixer.replaceTextRange([node.arguments[0].range[0], node.arguments[1].range[0]], "");
}
});
}
Expand Down
32 changes: 16 additions & 16 deletions tests/lib/rules/prefer-object-has-own.js
View file
Original file line number Diff line number Diff line change
Expand Up @@ -84,7 +84,7 @@ ruleTester.run("prefer-object-has-own", rule, {
invalid: [
{
code: "Object.hasOwnProperty.call(obj, 'foo')",
output: "Object.hasOwn('foo')",
output: "Object.hasOwn(obj, 'foo')",
errors: [{
messageId: "useHasOwn",
line: 1,
Expand All @@ -95,7 +95,7 @@ ruleTester.run("prefer-object-has-own", rule, {
},
{
code: "Object.hasOwnProperty.call(obj, property)",
output: "Object.hasOwn(property)",
output: "Object.hasOwn(obj, property)",
errors: [{
messageId: "useHasOwn",
line: 1,
Expand All @@ -106,7 +106,7 @@ ruleTester.run("prefer-object-has-own", rule, {
},
{
code: "Object.prototype.hasOwnProperty.call(obj, 'foo')",
output: "Object.hasOwn('foo')",
output: "Object.hasOwn(obj, 'foo')",
errors: [{
messageId: "useHasOwn",
line: 1,
Expand All @@ -117,7 +117,7 @@ ruleTester.run("prefer-object-has-own", rule, {
},
{
code: "({}).hasOwnProperty.call(obj, 'foo')",
output: "Object.hasOwn('foo')",
output: "Object.hasOwn(obj, 'foo')",
errors: [{
messageId: "useHasOwn",
line: 1,
Expand All @@ -128,7 +128,7 @@ ruleTester.run("prefer-object-has-own", rule, {
},
{
code: "const hasProperty = Object.prototype.hasOwnProperty.call(object, property);",
output: "const hasProperty = Object.hasOwn(property);",
output: "const hasProperty = Object.hasOwn(object, property);",
errors: [{
messageId: "useHasOwn",
line: 1,
Expand All @@ -139,7 +139,7 @@ ruleTester.run("prefer-object-has-own", rule, {
},
{
code: "const hasProperty = (( Object.prototype.hasOwnProperty.call(object, property) ));",
output: "const hasProperty = (( Object.hasOwn(property) ));",
output: "const hasProperty = (( Object.hasOwn(object, property) ));",
errors: [{
messageId: "useHasOwn",
line: 1,
Expand All @@ -150,7 +150,7 @@ ruleTester.run("prefer-object-has-own", rule, {
},
{
code: "const hasProperty = (( Object.prototype.hasOwnProperty.call ))(object, property);",
output: "const hasProperty = (( Object.hasOwn ))(property);",
output: "const hasProperty = (( Object.hasOwn ))(object, property);",
errors: [{
messageId: "useHasOwn",
line: 1,
Expand All @@ -161,7 +161,7 @@ ruleTester.run("prefer-object-has-own", rule, {
},
{
code: "const hasProperty = (( Object.prototype.hasOwnProperty )).call(object, property);",
output: "const hasProperty = Object.hasOwn(property);",
output: "const hasProperty = Object.hasOwn(object, property);",
errors: [{
messageId: "useHasOwn",
line: 1,
Expand All @@ -172,7 +172,7 @@ ruleTester.run("prefer-object-has-own", rule, {
},
{
code: "const hasProperty = (( Object.prototype )).hasOwnProperty.call(object, property);",
output: "const hasProperty = Object.hasOwn(property);",
output: "const hasProperty = Object.hasOwn(object, property);",
errors: [{
messageId: "useHasOwn",
line: 1,
Expand All @@ -183,7 +183,7 @@ ruleTester.run("prefer-object-has-own", rule, {
},
{
code: "const hasProperty = (( Object )).prototype.hasOwnProperty.call(object, property);",
output: "const hasProperty = Object.hasOwn(property);",
output: "const hasProperty = Object.hasOwn(object, property);",
errors: [{
messageId: "useHasOwn",
line: 1,
Expand All @@ -194,7 +194,7 @@ ruleTester.run("prefer-object-has-own", rule, {
},
{
code: "const hasProperty = {}.hasOwnProperty.call(object, property);",
output: "const hasProperty = Object.hasOwn(property);",
output: "const hasProperty = Object.hasOwn(object, property);",
errors: [{
messageId: "useHasOwn",
line: 1,
Expand All @@ -205,7 +205,7 @@ ruleTester.run("prefer-object-has-own", rule, {
},
{
code: "const hasProperty = (( {}.hasOwnProperty.call(object, property) ));",
output: "const hasProperty = (( Object.hasOwn(property) ));",
output: "const hasProperty = (( Object.hasOwn(object, property) ));",
errors: [{
messageId: "useHasOwn",
line: 1,
Expand All @@ -216,7 +216,7 @@ ruleTester.run("prefer-object-has-own", rule, {
},
{
code: "const hasProperty = (( {}.hasOwnProperty.call ))(object, property);",
output: "const hasProperty = (( Object.hasOwn ))(property);",
output: "const hasProperty = (( Object.hasOwn ))(object, property);",
errors: [{
messageId: "useHasOwn",
line: 1,
Expand All @@ -227,7 +227,7 @@ ruleTester.run("prefer-object-has-own", rule, {
},
{
code: "const hasProperty = (( {}.hasOwnProperty )).call(object, property);",
output: "const hasProperty = Object.hasOwn(property);",
output: "const hasProperty = Object.hasOwn(object, property);",
errors: [{
messageId: "useHasOwn",
line: 1,
Expand All @@ -238,7 +238,7 @@ ruleTester.run("prefer-object-has-own", rule, {
},
{
code: "const hasProperty = (( {} )).hasOwnProperty.call(object, property);",
output: "const hasProperty = Object.hasOwn(property);",
output: "const hasProperty = Object.hasOwn(object, property);",
errors: [{
messageId: "useHasOwn",
line: 1,
Expand All @@ -249,7 +249,7 @@ ruleTester.run("prefer-object-has-own", rule, {
},
{
code: "function foo(){return {}.hasOwnProperty.call(object, property)}",
output: "function foo(){return Object.hasOwn(property)}",
output: "function foo(){return Object.hasOwn(object, property)}",
errors: [{
messageId: "useHasOwn",
line: 1,
Expand Down

0 comments on commit e14c304

Please sign in to comment.