Update: Fix incorrect default value for position (#10670)

eslint · Jul 28, 2018 · e37a593 · e37a593
1 parent 8084bfc
commit e37a593
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 1 deletion.
diff --git a/lib/rules/line-comment-position.js b/lib/rules/line-comment-position.js
@@ -59,7 +59,7 @@ module.exports = {
             above = !options || options === "above";
 
         } else {
-            above = options.position === "above";
+            above = !options.position || options.position === "above";
             ignorePattern = options.ignorePattern;
 
             if (options.hasOwnProperty("applyDefaultIgnorePatterns")) {

diff --git a/tests/lib/rules/line-comment-position.js b/tests/lib/rules/line-comment-position.js
@@ -76,6 +76,10 @@ ruleTester.run("line-comment-position", rule, {
         {
             code: "// pragma valid comment\n1 + 1;",
             options: [{ position: "beside", ignorePattern: "pragma|linter" }]
+        },
+        {
+            code: "// above\n1 + 1; // ignored",
+            options: [{ ignorePattern: "ignored" }]
         }
     ],