Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade: devdeps and deps to latest #10622

Merged
merged 5 commits into from Aug 23, 2018
Merged

Conversation

aladdin-add
Copy link
Member

What is the purpose of this pull request? (put an "X" next to item)

[ ] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofixing to a rule
[ ] Add a CLI option
[ ] Add something to the core
[x] Other, please explain:

What changes did you make? (Give an overview)

Is there anything you'd like reviewers to focus on?

confirmed all tests passed, is there some deps might break?

@aladdin-add aladdin-add added the chore This change is not user-facing label Jul 18, 2018
@aladdin-add aladdin-add changed the title Upgrade: deps Upgrade: devdeps and deps to latest Jul 18, 2018
Copy link
Member

@platinumazure platinumazure left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM assuming none of these have breaking changes which would affect us. (I recommend reading the changelog for each project to get an idea of what the breaking changes for each major version bump would be.)

@not-an-aardvark not-an-aardvark added the do not merge This pull request should not be merged yet label Jul 21, 2018
@not-an-aardvark
Copy link
Member

Adding "do not merge" because I think we should manually look through the breaking changes to make sure that none of them will result in compatibility issues for ESLint users.

@platinumazure platinumazure added upgrade This change is related to a dependency upgrade and removed chore This change is not user-facing labels Jul 22, 2018
@aladdin-add aladdin-add reopened this Jul 26, 2018
@aladdin-add
Copy link
Member Author

should we consider merging this PR? since I'm not seeing any changes might break eslint.

sinon devDep 3.3.0 ❯ 6.1.5 has some more work to upgrade, I can do it in another PR later. 😄
string.prototype.matchall seems no longer used in the codebase. am I missing something?

@not-an-aardvark not-an-aardvark removed the do not merge This pull request should not be merged yet label Aug 12, 2018
@aladdin-add aladdin-add added do not merge This pull request should not be merged yet and removed do not merge This pull request should not be merged yet labels Aug 20, 2018
@aladdin-add aladdin-add merged commit 10690b7 into eslint:master Aug 23, 2018
@aladdin-add aladdin-add deleted the upgrade/deps branch August 23, 2018 04:40
@eslint-deprecated eslint-deprecated bot locked and limited conversation to collaborators Feb 20, 2019
@eslint-deprecated eslint-deprecated bot added the archived due to age This issue has been archived; please open a new issue for any further discussion label Feb 20, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
archived due to age This issue has been archived; please open a new issue for any further discussion upgrade This change is related to a dependency upgrade
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants