New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade: devdeps and deps to latest #10622
Conversation
ba8deaf
to
6978250
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM assuming none of these have breaking changes which would affect us. (I recommend reading the changelog for each project to get an idea of what the breaking changes for each major version bump would be.)
Adding "do not merge" because I think we should manually look through the breaking changes to make sure that none of them will result in compatibility issues for ESLint users. |
fa784a8
to
8bec08e
Compare
8bec08e
to
ea17e27
Compare
should we consider merging this PR? since I'm not seeing any changes might break eslint. sinon devDep 3.3.0 ❯ 6.1.5 has some more work to upgrade, I can do it in another PR later. 😄 |
88c4e6f
to
96d92eb
Compare
What is the purpose of this pull request? (put an "X" next to item)
[ ] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofixing to a rule
[ ] Add a CLI option
[ ] Add something to the core
[x] Other, please explain:
What changes did you make? (Give an overview)
Is there anything you'd like reviewers to focus on?
confirmed all tests passed, is there some deps might break?