Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update: Bump inquirer to version 6 #10735

Closed
wants to merge 1 commit into from
Closed

Update: Bump inquirer to version 6 #10735

wants to merge 1 commit into from

Conversation

realityking
Copy link
Contributor

What is the purpose of this pull request? (put an "X" next to item)

[ ] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofixing to a rule
[ ] Add a CLI option
[ ] Add something to the core
[X] Other, please explain:

Bump inquirer to version 6.

Full changelog: https://github.com/SBoudrias/Inquirer.js/releases/tag/v6.0.0

The only breaking change is the update of Rx.js to v6. Since eslint doesn't directly access Rx.js, this doesn't affect eslint.

What changes did you make? (Give an overview)

Is there anything you'd like reviewers to focus on?

@eslint-deprecated eslint-deprecated bot added the triage An ESLint team member will look at this issue soon label Aug 6, 2018
@kaicataldo
Copy link
Member

Thanks for the PR! What does upgrading inquirer buy us right now?

@kaicataldo kaicataldo added evaluating The team will evaluate this issue to decide whether it meets the criteria for inclusion upgrade This change is related to a dependency upgrade and removed triage An ESLint team member will look at this issue soon labels Aug 6, 2018
@realityking
Copy link
Contributor Author

Not much except better deduplication with other tools that use it as well and are staying up to date.

In my case, the project I work on currently loads 3 inquirer versions and this would cut it down to two (and remove the divergent subdepebdencies)

@aladdin-add
Copy link
Member

there is another PR #10622, upgrade inquirer@6.1.0

@realityking
Copy link
Contributor Author

Fixed with #10622 / 10690b7

@realityking realityking deleted the bump-inquirer branch August 28, 2018 09:13
@eslint-deprecated eslint-deprecated bot locked and limited conversation to collaborators Feb 25, 2019
@eslint-deprecated eslint-deprecated bot added the archived due to age This issue has been archived; please open a new issue for any further discussion label Feb 25, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
archived due to age This issue has been archived; please open a new issue for any further discussion evaluating The team will evaluate this issue to decide whether it meets the criteria for inclusion upgrade This change is related to a dependency upgrade
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants