Chore: use eslintrc overrides #10677
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -1,10 +1,6 @@ | |||
| extends: | |||
| - "eslint:recommended" | |||
| - "plugin:node/recommended" | |||
|
|
|||
| plugins: | |||
| - "node" | |||
There was a problem hiding this comment.
Why are you removing the Node plugin here? It seems we should specify it if we're going to extend from "plugin:node/recommended".
There was a problem hiding this comment.
it has been added in node/recommended(previous included just since it has not been released):
https://github.com/mysticatea/eslint-plugin-node/blob/master/lib/configs/recommended.json#L13
There was a problem hiding this comment.
Oh, weird. I thought the plugins entry was necessary in order to reference the plugin config. If it's not required and everything works fine, we could remove it here.
There was a problem hiding this comment.
I created another PR(#10685 ), since it seems not related to this PR.
ilyavolodin
approved these changes
Aug 4, 2018
eslint-deprecated
bot
added
the
archived due to age
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of this pull request? (put an "X" next to item)
[ ] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofixing to a rule
[ ] Add a CLI option
[ ] Add something to the core
[x] Other, please explain:
What changes did you make? (Give an overview)
similar to #10566
Is there anything you'd like reviewers to focus on?
no