Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Chore: use eslintrc overrides #10677

Merged
merged 4 commits into from
Aug 4, 2018
Merged

Chore: use eslintrc overrides #10677

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
70758f4
Chore: use eslintrc overrides
aladdin-add Jul 26, 2018
dd89982
Chore: rm tools/internal-rules/eslintrc
aladdin-add Jul 26, 2018
306fedf
Chore: revert eslint-config-eslint
aladdin-add Jul 26, 2018
11a7646
Chore: simplify eslintrc
aladdin-add Aug 1, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
7 changes: 7 additions & 0 deletions .eslintrc.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,13 @@ module.exports = {
},
overrides: [
{
files: ["lib/rules/*"],
rules: {
"rulesdir/no-invalid-meta": "error",
"rulesdir/consistent-docs-description": "error",
"rulesdir/consistent-docs-url": "error"
}
}, {
files: ["tests/**/*"],
env: { mocha: true },
rules: {
Expand Down
4 changes: 0 additions & 4 deletions lib/rules/.eslintrc.yml
View file
Open in desktop

This file was deleted.

4 changes: 0 additions & 4 deletions packages/eslint-config-eslint/default.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,10 +1,6 @@
extends:
- "eslint:recommended"
- "plugin:node/recommended"

plugins:
- "node"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are you removing the Node plugin here? It seems we should specify it if we're going to extend from "plugin:node/recommended".

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it has been added in node/recommended(previous included just since it has not been released):
https://github.com/mysticatea/eslint-plugin-node/blob/master/lib/configs/recommended.json#L13

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, weird. I thought the plugins entry was necessary in order to reference the plugin config. If it's not required and everything works fine, we could remove it here.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I created another PR(#10685 ), since it seems not related to this PR.


rules:
array-bracket-spacing: "error"
array-callback-return: "error"
Expand Down