Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Documentation: Broken jscs.info URLs #10732

Closed
kaicataldo opened this issue Aug 5, 2018 · 5 comments
Closed

Documentation: Broken jscs.info URLs #10732

kaicataldo opened this issue Aug 5, 2018 · 5 comments
Labels
accepted There is consensus among the team that this change meets the criteria for inclusion archived due to age This issue has been archived; please open a new issue for any further discussion documentation Relates to ESLint's documentation good first issue Good for people who haven't worked on ESLint before help wanted The team would welcome a contribution from the community for this issue

Comments

@kaicataldo
Copy link
Member

We still have links to the jscs.info domain in our documentation. Work has been started in this PR, but as pointed out in this comment, it looks like we have a few more here.
@kaicataldo kaicataldo added documentation Relates to ESLint's documentation good first issue Good for people who haven't worked on ESLint before accepted There is consensus among the team that this change meets the criteria for inclusion help wanted The team would welcome a contribution from the community for this issue labels Aug 5, 2018
@hzoo
Copy link
Member

hzoo commented Aug 5, 2018 •
edited

Not sure who owns the domain but I recovered the old github url if we'd still want to refer to it. https://jscs-dev.github.io/ should work now (repo is https://github.com/jscs-dev/jscs-dev.github.io). So just need to replace those links to jscs-dev.github.io instead of jscs.info (if that's desirable)

@kaicataldo
Copy link
Member Author

That would be great! Seems like the work here is to revert the PR I linked at the top of the issue and make the change @hzoo suggests above.

@kaicataldo kaicataldo mentioned this issue Aug 6, 2018
Closed
@pkuczynski
Copy link
Contributor

I can revert my previous PR if you think its worth it?

@kaicataldo
Copy link
Member Author

I think that makes sense! Would you also like to update the URLs as suggested here?

@platinumazure
Copy link
Member

@pkuczynski Friendly ping: Still interested in writing a couple of PRs here? Anything we can do to help?

santanaG added a commit to santanaG/eslint that referenced this issue Aug 17, 2018
@santanaG
Docs: Broken jscs.info URLs (Fixes eslint#10732)
df1b9a7
@eslint-deprecated eslint-deprecated bot locked and limited conversation to collaborators Feb 14, 2019
@eslint-deprecated eslint-deprecated bot added the archived due to age This issue has been archived; please open a new issue for any further discussion label Feb 14, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
accepted There is consensus among the team that this change meets the criteria for inclusion archived due to age This issue has been archived; please open a new issue for any further discussion documentation Relates to ESLint's documentation good first issue Good for people who haven't worked on ESLint before help wanted The team would welcome a contribution from the community for this issue
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@platinumazure @pkuczynski @hzoo @kaicataldo