Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: remove links to terminated jscs.info domain #10736

Closed
wants to merge 1 commit into from
Closed

Docs: remove links to terminated jscs.info domain #10736

wants to merge 1 commit into from

Conversation

pkuczynski
Copy link
Contributor

What is the purpose of this pull request? (put an "X" next to item)

[X] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofixing to a rule
[ ] Add a CLI option
[ ] Add something to the core
[ ] Other, please explain:

What changes did you make? (Give an overview)

Removed reference to jscs.info domain missed in #10706

Is there anything you'd like reviewers to focus on?

Not really I think. Maybe just a bit different formatting in a form of a sublist. I will follow up with PR applying the same pattern in other rules.

@eslint-deprecated eslint-deprecated bot added the triage An ESLint team member will look at this issue soon label Aug 6, 2018
@kaicataldo
Copy link
Member

kaicataldo commented Aug 6, 2018

Hi! Thanks for the PR. Just so you're aware, this is being discussed in this issue. It sounds like we can actually link to the GitHub pages hosted site, which I think is preferable to removing the links entirely.

@pkuczynski
Copy link
Contributor Author

As I can see that issue was raised after my PR got merged :) I can prepare a new one if you think it’s worth it?

@kaicataldo
Copy link
Member

That would be great!

@kaicataldo
Copy link
Member

Hi there, just wanted to check in on this and see if you needed assistance with anything. Thanks!

@pkuczynski
Copy link
Contributor Author

I think this has been fixed in #10771 and should be closed...

@pkuczynski pkuczynski closed this Sep 12, 2018
@pkuczynski pkuczynski deleted the remove-jscs2 branch September 12, 2018 22:21
@eslint-deprecated eslint-deprecated bot locked and limited conversation to collaborators Mar 12, 2019
@eslint-deprecated eslint-deprecated bot added the archived due to age This issue has been archived; please open a new issue for any further discussion label Mar 12, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
archived due to age This issue has been archived; please open a new issue for any further discussion triage An ESLint team member will look at this issue soon
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants