Build: Add karma-chrome-launcher support #11027
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aladdin-add
added
build
g-plane
reviewed
Nov 7, 2018
|
Apologies if this was discussed elsewhere, but: Why do we want to do this in the first place? Is this to help validate our unofficial browser capability? |
|
I think it was discussed in #10898. it was introduced as Phantomjs no longer being maintained, than to help validate our unofficial browser capability. |
aladdin-add
force-pushed
the
revert-10973-revert-chrome-headless
branch
from
25a2dce
to
c3a7aaa
Compare
|
Once we are going to use Chrome, |
|
@g-plane switching to chrome does not mean dropping support IE. so I'm not sure we can remove these deps. but it seems a good idea to upgrade babel 7, since |
not-an-aardvark
approved these changes
Jan 4, 2019
|
Ignoring the CLA checker because the name changed and the email address is the same (also see #11220 (comment)). |
eslint-deprecated
bot
added
the
archived due to age
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of this pull request? (put an "X" next to item)
[ ] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofixing to a rule
[ ] Add a CLI option
[ ] Add something to the core
[x ] Other, please explain:
What changes did you make? (Give an overview)
the change was merged in #10898, but was reverted in #10973, due to a release build failing on Jenkins.
the change added it back again, and added
puppeteerin dev, to fix the build failing.Is there anything you'd like reviewers to focus on?
what can we do to make sure it fixed the issue? (e.g. run on Jenkins)