New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Build: Add karma-chrome-launcher support #11027
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missing process.env.CHROME_BIN = require("puppeteer").executablePath()
at the header of karma.conf.js
.
Apologies if this was discussed elsewhere, but: Why do we want to do this in the first place? Is this to help validate our unofficial browser capability? |
I think it was discussed in #10898. it was introduced as Phantomjs no longer being maintained, than to help validate our unofficial browser capability. |
25a2dce
to
c3a7aaa
Compare
Once we are going to use Chrome, |
@g-plane switching to chrome does not mean dropping support IE. so I'm not sure we can remove these deps. but it seems a good idea to upgrade babel 7, since |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
I created a test build on the Jenkins server and confirmed that the tests on this branch pass.
Ignoring the CLA checker because the name changed and the email address is the same (also see #11220 (comment)). |
What is the purpose of this pull request? (put an "X" next to item)
[ ] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofixing to a rule
[ ] Add a CLI option
[ ] Add something to the core
[x ] Other, please explain:
What changes did you make? (Give an overview)
the change was merged in #10898, but was reverted in #10973, due to a release build failing on Jenkins.
the change added it back again, and added
puppeteer
in dev, to fix the build failing.Is there anything you'd like reviewers to focus on?
what can we do to make sure it fixed the issue? (e.g. run on Jenkins)