Chore: remove undocumented Linter#rules property (refs #9161)
#11335
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This removes the undocumented `rules` property from `Linter` instances, as part of the effort to remove undocumented API surface from `Linter` (also see #9161). Config processing now exclusively uses `Linter`'s public API when defining rules. As a side-effect, the rule map utility in `lib/rules.js` no longer needs to access the filesystem, so we can remove the odd code generation logic from the browserify build.
not-an-aardvark
changed the title
Linter.rules property (refs #9161)Linter#rules property (refs #9161)
platinumazure
requested changes
Jan 30, 2019
|
Good catch, I'd assumed |
platinumazure
approved these changes
Jan 30, 2019
ilyavolodin
approved these changes
Jan 30, 2019
eslint-deprecated
bot
added
the
archived due to age
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of this pull request? (put an "X" next to item)
[x] Other, please explain:
What changes did you make? (Give an overview)
This removes the undocumented
rulesproperty fromLinterinstances, as part of the effort to remove undocumented API surface fromLinter(also see #9161). Config processing now exclusively usesLinter's public API when defining rules. As a side-effect, the rule map utility inlib/rules.jsno longer needs to access the filesystem, so we can remove the odd code generation logic from the browserify build.Is there anything you'd like reviewers to focus on?
Nothing in particular