Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Chore: remove undocumented Linter#rules property (refs #9161) #11335

Merged
merged 3 commits into from Jan 30, 2019
Merged

Chore: remove undocumented Linter#rules property (refs #9161) #11335

merged 3 commits into from Jan 30, 2019

Commits on Jan 30, 2019

  1. Chore: remove undocumented Linter.rules property (refs #9161) 

    This removes the undocumented `rules` property from `Linter` instances, as part of the effort to remove undocumented API surface from `Linter` (also see #9161). Config processing now exclusively uses `Linter`'s public API when defining rules. As a side-effect, the rule map utility in `lib/rules.js` no longer needs to access the filesystem, so we can remove the odd code generation logic from the browserify build.
    @not-an-aardvark
    not-an-aardvark committed Jan 30, 2019
    Configuration menu
    Copy the full SHA
    1676355 View commit details
    Browse the repository at this point in the history

  2. Keep numbers in comments up to date

    @not-an-aardvark
    not-an-aardvark committed Jan 30, 2019
    Configuration menu
    Copy the full SHA
    7eaed27 View commit details
    Browse the repository at this point in the history

  3. Add tests for loading rules from a directory

    @not-an-aardvark
    not-an-aardvark committed Jan 30, 2019
    Configuration menu
    Copy the full SHA
    c5dc5e8 View commit details
    Browse the repository at this point in the history