Chore: refactor code #12113
Merged
Chore: refactor code #12113
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eslint-deprecated
bot
added
the
triage
kaicataldo
reviewed
Aug 18, 2019
kaicataldo
added
chore
jamesgeorge007
force-pushed
the
feat/refactor
branch
2 times, most recently
from
9d1dff1
to
5712bdb
Compare
jamesgeorge007
force-pushed
the
feat/refactor
branch
from
5712bdb
to
7cddd55
Compare
kaicataldo
reviewed
Aug 19, 2019
g-plane
reviewed
Aug 19, 2019
jamesgeorge007
force-pushed
the
feat/refactor
branch
from
da67d0b
to
771ffab
Compare
platinumazure
requested changes
Aug 19, 2019
have deps as a Set rather than an array
platinumazure
requested changes
Aug 19, 2019
|
It does appear this isn’t tested, since tests were passing in the last iteration. It would be great if we could cover it with a test case. |
|
@jamesgeorge007 Looks like tests are failing. Do you mind fixing them up? |
|
Thanks for what?
…On Thu, Aug 29, 2019, 7:48 AM Kevin Partington ***@***.***> wrote:
***@***.**** approved this pull request.
LGTM, thanks!
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#12113?email_source=notifications&email_token=AMATDU4AF5M7H2BJMKCMP2TQG7ASHA5CNFSM4IMROHHKYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCDDE26Q#pullrequestreview-281431418>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AMATDU4QQW3HQMTJIP5JSQ3QG7ASHANCNFSM4IMROHHA>
.
|
|
@tacoto12 That wasn't addressed to you. It looks like you've somehow been subscribed to this thread and other threads through GitHub. Please sign in on GitHub and unsubscribe. Commenting/replying won't help in your case as you will just continue to get notifications. If you have questions, please reach out to GitHub Support. Thanks! |
This was referenced Sep 9, 2019
This was referenced Sep 24, 2019
This was referenced Oct 22, 2019
This was referenced Nov 9, 2019
eslint-deprecated
bot
added
the
archived due to age
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of this pull request? (put an "X" next to item)
[ ] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofixing to a rule
[ ] Add a CLI option
[ ] Add something to the core
[x] Other, please explain: code refactoring
What changes did you make? (Give an overview)
code refactoring
Is there anything you'd like reviewers to focus on?
Nope