Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Chore: refactor code #12113

Merged
merged 7 commits into from Aug 30, 2019
Merged

Chore: refactor code #12113

Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
4f1ac1f
Chore: refactor code
jamesgeorge007 Aug 18, 2019
7cddd55
Fix: minor tweak
jamesgeorge007 Aug 19, 2019
771ffab
Minor tweak
jamesgeorge007 Aug 19, 2019
eac59c3
Fix: lint
jamesgeorge007 Aug 19, 2019
0bd8959
Fix: minor tweak
jamesgeorge007 Aug 19, 2019
34fefa4
Fix: tweak
jamesgeorge007 Aug 20, 2019
75c65cd
fix: typo
jamesgeorge007 Aug 24, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
16 changes: 8 additions & 8 deletions lib/init/npm-utils.js
View file
Open in desktop
Expand Up @@ -98,7 +98,7 @@ function fetchPeerDependencies(packageName) {
* and values are booleans indicating installation.
*/
function check(packages, opt) {
let deps = [];
const deps = new Set();
const pkgJson = (opt) ? findPackageJson(opt.startDir) : findPackageJson();
let fileJson;

Expand All @@ -119,14 +119,14 @@ function check(packages, opt) {
throw error;
}

if (opt.devDependencies && typeof fileJson.devDependencies === "object") {
deps = deps.concat(Object.keys(fileJson.devDependencies));
}
if (opt.dependencies && typeof fileJson.dependencies === "object") {
deps = deps.concat(Object.keys(fileJson.dependencies));
}
["dependencies", "devDependencies"].forEach(key => {
jamesgeorge007 marked this conversation as resolved.
Show resolved Hide resolved
if (opt[key] && typeof fileJson[key] === "object") {
Object.keys(fileJson[key]).forEach(dep => deps.add(dep));
}
});

return packages.reduce((status, pkg) => {
status[pkg] = deps.indexOf(pkg) !== -1;
status[pkg] = deps.has(pkg);
return status;
}, {});
}
Expand Down