Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: remove custom plugins from replacedBy metadata #13274

Merged
merged 1 commit into from May 11, 2020

Conversation

kaicataldo
Copy link
Member

Prerequisites checklist

  • I have read the contributing guidelines.
  • The team has reached consensus on the changes proposed in this pull request. If not, I understand that the evaluation process will begin with this pull request and won't be merged until the team has reached consensus.

What is the purpose of this pull request? (put an "X" next to an item)

[ ] Documentation update
[X] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofixing to a rule
[ ] Add a CLI option
[ ] Add something to the core
[ ] Other, please explain:

What changes did you make? (Give an overview)

The deprecated rules currently link to broken links.

Following up on eslint/archive-website#727 (which fixes the site immediately), and since we don't want to be in the business of keeping track of custom plugins, this PR removes the replacedBy elements for the deprecated Node.js/CommonJS to be consistent with the deprecated JSDoc rules.

Is there anything you'd like reviewers to focus on?

Nothing in particular.

@eslint-deprecated eslint-deprecated bot added the triage An ESLint team member will look at this issue soon label May 8, 2020
@kaicataldo kaicataldo added bug ESLint is working incorrectly and removed triage An ESLint team member will look at this issue soon labels May 8, 2020
@kaicataldo kaicataldo changed the title Fix: remove custom plugins from replaceBy metadata Fix: remove custom plugins from replacedBy metadata May 8, 2020
@kaicataldo kaicataldo merged commit 2c778fb into master May 11, 2020
@kaicataldo kaicataldo deleted the node-replaced-by-fix branch May 11, 2020 21:42
@eslint-deprecated eslint-deprecated bot locked and limited conversation to collaborators Nov 8, 2020
@eslint-deprecated eslint-deprecated bot added the archived due to age This issue has been archived; please open a new issue for any further discussion label Nov 8, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
archived due to age This issue has been archived; please open a new issue for any further discussion bug ESLint is working incorrectly
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants