This repository has been archived by the owner on Nov 10, 2022. It is now read-only.
Fix: don't render links when plugin replaces core rule #727
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eslint-deprecated
bot
added
the
triage
kaicataldo
force-pushed
the
fix-replaced-by
branch
from
52021ef
to
ec37526
Compare
kaicataldo
added
bug
|
Deploy preview for eslint ready! Built with commit ec37526 |
2 tasks
mysticatea
approved these changes
May 8, 2020
nzakas
approved these changes
May 8, 2020
nzakas
approved these changes
May 9, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fun with programming in Liquid! The deprecated rules currently link to broken links. To avoid having to keep track of 3rd party plugins, we can just not render namespaced rules.
For consistency, I will also follow up with a PR that removes these
replacedByfields in the deprecated Node.js/CommonJS rules to match what we did with the deprecated JSDoc rules.Edit
Follow up PR: eslint/eslint#13274