Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update: reporting location for semi-spacing (refs #12334) #13285

Merged
merged 6 commits into from May 22, 2020

Conversation

anikethsaha
Copy link
Member

@anikethsaha anikethsaha commented May 12, 2020

Prerequisites checklist

  • I have read the contributing guidelines.
  • The team has reached consensus on the changes proposed in this pull request. If not, I understand that the evaluation process will begin with this pull request and won't be merged until the team has reached consensus.

What is the purpose of this pull request? (put an "X" next to an item)

[ ] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[X] Changes an existing rule (template)
[ ] Add autofixing to a rule
[ ] Add a CLI option
[ ] Add something to the core
[ ] Other, please explain:

What changes did you make? (Give an overview)

Updated the location when is there unexpected space (both for before and after)

Currently

var a = 'b'   ;
          //  ^ it will report here instead of the spaces

with this change

var a = 'b'   ;
        // ^^^  it will report here

Is there anything you'd like reviewers to focus on?

For missing space it currently reports

var a = 'a';var b = 'b';
       //  ^ it reports here i.e over the `;`

I think it should report the next token after ; right ? i.e v in this case.

I didn't make this change for the missing space, let me know if this is fine to change !

repl

@eslint-deprecated eslint-deprecated bot added the triage An ESLint team member will look at this issue soon label May 12, 2020
@mdjermanovic mdjermanovic added accepted There is consensus among the team that this change meets the criteria for inclusion enhancement This change enhances an existing feature of ESLint rule Relates to ESLint's core rules and removed triage An ESLint team member will look at this issue soon labels May 16, 2020
lib/rules/semi-spacing.js Outdated Show resolved Hide resolved
lib/rules/semi-spacing.js Outdated Show resolved Hide resolved
lib/rules/semi-spacing.js Outdated Show resolved Hide resolved
@mdjermanovic mdjermanovic changed the title Update: reporting location for unexpected space (refs #12334) Update: reporting location for semi-spacing (refs #12334) May 17, 2020
lib/rules/semi-spacing.js Outdated Show resolved Hide resolved
tests/lib/rules/semi-spacing.js Outdated Show resolved Hide resolved
tests/lib/rules/semi-spacing.js Outdated Show resolved Hide resolved
lib/rules/semi-spacing.js Outdated Show resolved Hide resolved
lib/rules/semi-spacing.js Show resolved Hide resolved
Copy link
Member

@mdjermanovic mdjermanovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@kaicataldo
Copy link
Member

LGTM, thank you!

@kaicataldo kaicataldo merged commit a195141 into eslint:master May 22, 2020
@eslint-deprecated eslint-deprecated bot locked and limited conversation to collaborators Nov 19, 2020
@eslint-deprecated eslint-deprecated bot added the archived due to age This issue has been archived; please open a new issue for any further discussion label Nov 19, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
accepted There is consensus among the team that this change meets the criteria for inclusion archived due to age This issue has been archived; please open a new issue for any further discussion enhancement This change enhances an existing feature of ESLint rule Relates to ESLint's core rules
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants