New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update: reporting location for semi-spacing (refs #12334) #13285
Merged
kaicataldo
merged 6 commits into
eslint:master
from
anikethsaha:fixes-12334-semi-spacing
May 22, 2020
Merged
Update: reporting location for semi-spacing (refs #12334) #13285
kaicataldo
merged 6 commits into
eslint:master
from
anikethsaha:fixes-12334-semi-spacing
May 22, 2020
+221
−35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eslint-deprecated
bot
added
the
triage
An ESLint team member will look at this issue soon
label
May 12, 2020
mdjermanovic
added
accepted
There is consensus among the team that this change meets the criteria for inclusion
enhancement
This change enhances an existing feature of ESLint
rule
Relates to ESLint's core rules
and removed
triage
An ESLint team member will look at this issue soon
labels
May 16, 2020
mdjermanovic
requested changes
May 16, 2020
mdjermanovic
changed the title
Update: reporting location for unexpected space (refs #12334)
Update: reporting location for semi-spacing (refs #12334)
May 17, 2020
mdjermanovic
requested changes
May 18, 2020
mdjermanovic
requested changes
May 21, 2020
mdjermanovic
approved these changes
May 21, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
kaicataldo
approved these changes
May 22, 2020
LGTM, thank you! |
eslint-deprecated
bot
added
the
archived due to age
This issue has been archived; please open a new issue for any further discussion
label
Nov 19, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
accepted
There is consensus among the team that this change meets the criteria for inclusion
archived due to age
This issue has been archived; please open a new issue for any further discussion
enhancement
This change enhances an existing feature of ESLint
rule
Relates to ESLint's core rules
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prerequisites checklist
What is the purpose of this pull request? (put an "X" next to an item)
[ ] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[X] Changes an existing rule (template)
[ ] Add autofixing to a rule
[ ] Add a CLI option
[ ] Add something to the core
[ ] Other, please explain:
What changes did you make? (Give an overview)
Updated the location when is there unexpected space (both for before and after)
Currently
with this change
Is there anything you'd like reviewers to focus on?
For missing space it currently reports
I think it should report the next token after
;
right ? i.ev
in this case.I didn't make this change for the missing space, let me know if this is fine to change !
repl