Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Crash with "arrow-body-style": ["error", "always"] #14633

Closed
atiupin opened this issue May 26, 2021 · 1 comment · Fixed by #14635
Closed

Crash with "arrow-body-style": ["error", "always"] #14633

atiupin opened this issue May 26, 2021 · 1 comment · Fixed by #14635
Labels
accepted There is consensus among the team that this change meets the criteria for inclusion archived due to age This issue has been archived; please open a new issue for any further discussion bug ESLint is working incorrectly repro:yes rule Relates to ESLint's core rules
Projects
Triage

Comments

@atiupin
Copy link

atiupin commented May 26, 2021 •
edited

Environment Info

Node version: v12.19.0
npm version: v6.14.8
Local ESLint version: v7.27.0 (Currently used)
Global ESLint version: Not found
Operating System: darwin 20.4.0

Parser

"@babel/eslint-parser": "7.14.3"

Description

ESLint breaks using rule "arrow-body-style": ["error", "always"] on a very specific function signature.

In my case it's const createMarker = (color) => ({ latitude, longitude }, index) => {};.

Other variations of arrow-body-style (never or as-needed) work fine.

DEMO
@atiupin atiupin added bug ESLint is working incorrectly repro:needed labels May 26, 2021
@eslint-github-bot eslint-github-bot bot added this to Needs Triage in Triage May 26, 2021
@aladdin-add
Copy link
Member

thx! confirmed, it also happened with the default parser.

@aladdin-add aladdin-add added accepted There is consensus among the team that this change meets the criteria for inclusion repro:yes and removed repro:needed labels May 26, 2021
@aladdin-add aladdin-add moved this from Needs Triage to Ready to Implement in Triage May 26, 2021
mdjermanovic added a commit that referenced this issue May 26, 2021
@mdjermanovic
Fix: arrow-body-style crash with object pattern (fixes #14633)
0a1c6a3
@mdjermanovic mdjermanovic added the rule Relates to ESLint's core rules label May 26, 2021
@mdjermanovic mdjermanovic mentioned this issue May 26, 2021
Merged
1 task
@mdjermanovic mdjermanovic moved this from Ready to Implement to Pull Request Opened in Triage May 26, 2021
@aladdin-add aladdin-add mentioned this issue May 27, 2021
Closed
Triage automation moved this from Pull Request Opened to Complete May 28, 2021
aladdin-add pushed a commit that referenced this issue May 28, 2021
@mdjermanovic
Fix: arrow-body-style crash with object pattern (fixes #14633) (#14635)
e4f111b
@eslint-github-bot eslint-github-bot bot locked and limited conversation to collaborators Nov 25, 2021
@eslint-github-bot eslint-github-bot bot added the archived due to age This issue has been archived; please open a new issue for any further discussion label Nov 25, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
accepted There is consensus among the team that this change meets the criteria for inclusion archived due to age This issue has been archived; please open a new issue for any further discussion bug ESLint is working incorrectly repro:yes rule Relates to ESLint's core rules
Projects
Triage
Archived in project
Triage
Complete
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix: arrow-body-style crash with object pattern (fixes #14633) eslint/eslint
3 participants
@atiupin @aladdin-add @mdjermanovic