New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade: @eslint/eslintrc@1.0.0 #14865
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eslint-github-bot
bot
added
the
triage
An ESLint team member will look at this issue soon
label
Aug 1, 2021
mdjermanovic
added
accepted
There is consensus among the team that this change meets the criteria for inclusion
upgrade
This change is related to a dependency upgrade
and removed
triage
An ESLint team member will look at this issue soon
labels
Aug 5, 2021
Browser Test is failing:
|
Opened eslint/eslintrc#51 |
mdjermanovic
force-pushed
the
eslintrc-esm
branch
from
August 6, 2021 16:20
3279c34
to
b728557
Compare
Published @eslint/eslintrc v1.0.0: https://github.com/eslint/eslintrc/releases/tag/v1.0.0 |
mdjermanovic
force-pushed
the
eslintrc-esm
branch
from
August 7, 2021 19:10
5315724
to
32ab587
Compare
mdjermanovic
changed the title
Upgrade: @eslint/eslintrc with
Upgrade: @eslint/eslintrc@1.0.0
Aug 7, 2021
exports
field
nzakas
approved these changes
Aug 10, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
btmills
approved these changes
Aug 14, 2021
eslint-github-bot
bot
added
the
archived due to age
This issue has been archived; please open a new issue for any further discussion
label
Feb 11, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
accepted
There is consensus among the team that this change meets the criteria for inclusion
archived due to age
This issue has been archived; please open a new issue for any further discussion
upgrade
This change is related to a dependency upgrade
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remaining steps:
@eslint/eslintrc
API.package.json
with the new version of@eslint/eslintrc
.Prerequisites checklist
What is the purpose of this pull request? (put an "X" next to an item)
[ ] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofixing to a rule
[ ] Add a CLI option
[ ] Add something to the core
[x] Other, please explain:
Updates ESLint to use
@eslint/eslintrc
version with the"exports"
field in package.json (eslint/eslintrc#39), presumably in v8.0.0.What changes did you make? (Give an overview)
require("@eslint/eslintrc/lib/shared/config-ops")
to use theLegacy
API from the main (and only) entry point.in-memory-fs
.Is there anything you'd like reviewers to focus on?
require("@eslint/eslintrc/lib/shared/config-ops")
and others instead ofLegacy
?in-memory-fs
would be a bit more complicated and untestable since we're not using it anymore (aside from one functiondefineInMemoryFs
), so I just removed the unused functions.Environments are imported using a "hack" with absolute paths, in order to test other changes. This will be fixed when we update Breaking: Switch to ESM (fixes #35) eslintrc#39.fixed