Docs: add class fields in func-names documentation (refs #14857) #14908
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mdjermanovic
added
rule
32 tasks
nzakas
approved these changes
Aug 9, 2021
bmish
added a commit
to bmish/eslint
that referenced
this pull request
Aug 11, 2021
* master:
Chore: Add rel/abs path tests in `no-restricted-{imports/modules}` rules (eslint#14910)
Upgrade: Debug 4.0.1 > 4.3.2 (eslint#14892)
Chore: add assertions on reporting location in `semi` (eslint#14899)
Fix: no-useless-computed-key edge cases with class fields (refs eslint#14857) (eslint#14903)
Upgrade: `js-yaml` to v4 (eslint#14890)
Fix: prefer-destructuring PrivateIdentifier false positive (refs eslint#14857) (eslint#14897)
Fix: dot-notation false positive with private identifier (refs eslint#14857) (eslint#14898)
Sponsors: Sync README with website
Sponsors: Sync README with website
Docs: improve rule details for `no-console` (fixes eslint#14793) (eslint#14901)
Update: check class fields in no-extra-parens (refs eslint#14857) (eslint#14906)
Docs: add class fields in no-multi-assign documentation (refs eslint#14857) (eslint#14907)
Docs: add class fields in func-names documentation (refs eslint#14857) (eslint#14908)
Upgrade: `eslint-visitor-keys` to v3 (eslint#14902)
Upgrade: `markdownlint` dev dependencies (eslint#14883)
Upgrade: @humanwhocodes/config-array to 0.6 (eslint#14891)
Chore: Specify Node 14.x for Verify Files CI job (eslint#14896)
12 tasks
eslint-github-bot
bot
added
the
archived due to age
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prerequisites checklist
What is the purpose of this pull request? (put an "X" next to an item)
[x] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofixing to a rule
[ ] Add a CLI option
[ ] Add something to the core
[ ] Other, please explain:
refs #14857, fixes #14591 (comment)
What changes did you make? (Give an overview)
Updated documentation for the
func-namesrule to clarify thatas-neededlogic isn't tied to ES6, and added examples with class fields and logical assignment operators.Is there anything you'd like reviewers to focus on?
I believe the reason to specify ES6 was an expectation that future specifications might add more cases where the name is automatically assigned, e.g.
a.b = function() {}, in which case the rule would become unpredictable for users and difficult to maintain (whether or not the name will be automatically assigned for the same syntax would depend on the targeted environment). However, that never happened, except for the cases with new syntax, so I think it's safe to say "per the ECMAScript specification" instead of "in an ES6 environment".