New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
formatters examples appear as html-encoded text #16676
Comments
let me check this issue. |
When using Here's how GitHub renders And this is how So I think it maybe more reasonable to decode the code block in the markdown source code instead of hacking on the new syntax highlighter with non-standard trick. Another benefit would be more readable code block. |
So, before #16606 contents of
- <%= formatterResults[formatterName].result %>
+ <%- formatterResults[formatterName].result %> |
As @chenxsan mentioned
Can we do this? @mdjermanovic thoughts? @chenxsan can we fix this issue as part of #16669 PR itself? |
Exactly, actually I can found some issues due to not being html-escaped before #16606. Here's a preview page from #16605, And here's the source code: As you can see, texts like And here's the rendered version of #16606: Back to this formatters' examples, I believe you're right. We no longer need to escape them here formatter-examples.md.ejs. I've pushed a fix in #16669 |
Is this problem related to #16669? If not, it would be better to fix this in a separate PR. |
More like an issue should be caught and fixed in #16606, though #16669 is a follow-up of #16606. I think it's better to fix in a separate PR. |
See https://eslint.org/docs/latest/user-guide/formatters/
For example, the
checkstyle
example used to look like this:But now it looks like this:
By checking deploy previews on PRs, it seems that this change was introduced by #16606
The text was updated successfully, but these errors were encountered: