feat: add new omitLastInOneLineClassBody option to the semi rule

[snitin315]

Prerequisites checklist

• I have read the contributing guidelines.

What is the purpose of this pull request? (put an "X" next to an item)

[x] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[x] Changes an existing rule (template)
[ ] Add autofix to a rule
[ ] Add a CLI option
[ ] Add something to the core
[ ] Other, please explain:

What changes did you make? (Give an overview)

Resolve #17035

1. This PR adds a new omitLastInOneLineClassBody option to the semi rule. The following code will not throw any error now:

   /*eslint semi: ["error", "always", { "omitLastInOneLineClassBody": true}] */
   
   export class SomeClass{
       logType(){
           console.log(this.type);
       }
   }
   
   export class Variant1 extends SomeClass{type=1}
   export class Variant2 extends SomeClass{type=2}

2. Also fixed the order of options in the semi-rule documentation

   • omitLastInOneLineClassBody and omitLastInOneLineBlock under "always".
   • beforeStatementContinuationChars under "never"

   before	after

Is there anything you'd like reviewers to focus on?

[netlify]

✅ Deploy Preview for docs-eslint canceled.

Name	Link
🔨 Latest commit	9fe8d3a
🔍 Latest deploy log	https://app.netlify.com/sites/docs-eslint/deploys/644a87c40a0eb3000848ff78

[mdjermanovic]

Per this condition, "omitLastInOneLineClassBody": true would also apply to blocks:

/* eslint semi: ["error", "always", { "omitLastInOneLineClassBody": true}] */

{ foo; } // false positive

It might be clearer to add a new function isLastInOneLinerClassBody.

[snitin315]

@mdjermanovic Good catch. Fixed.

[mdjermanovic]

Code and docs LGTM. I left a few suggestions about the tests.

[mdjermanovic]

Can you also add a few tests to verify that this option applies only to one-line class bodies, for example:

{
    code: "class C {\nfoo;}",
    options: ["always", { omitLastInOneLineClassBody: true }],
    parserOptions: { ecmaVersion: 2022 }
},
{
    code: "class C {foo;\n}",
    options: ["always", { omitLastInOneLineClassBody: true }],
    parserOptions: { ecmaVersion: 2022 }
},
{
    code: "class C {foo;\nbar;}",
    options: ["always", { omitLastInOneLineClassBody: true }],
    parserOptions: { ecmaVersion: 2022 }
}

and a test to verify that the false positive from #17105 (comment) has been fixed:

{
    code: "{ foo; }",
    options: ["always", { omitLastInOneLineClassBody: true }],
    parserOptions: { ecmaVersion: 2022 }
}

and a test to verify that the option applies to one-line class bodies even if the class definition is multiline:

{
    code: "class C\n{ foo }",
    options: ["always", { omitLastInOneLineClassBody: true }],
    parserOptions: { ecmaVersion: 2022 }
}

[mdjermanovic]

LGTM, thanks!

[mdjermanovic]

@snitin315 could you please submit this same change to docs/src/rules/semi.md again in a new PR, as we had to undo it due to #17225.

[snitin315]

Sure. I'll resend.