Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add new omitLastInOneLineClassBody option to the semi rule #17263

Merged
merged 1 commit into from Jun 11, 2023

Conversation

snitin315
Copy link
Contributor

@snitin315 snitin315 commented Jun 10, 2023

Prerequisites checklist

What is the purpose of this pull request? (put an "X" next to an item)

[x] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofix to a rule
[ ] Add a CLI option
[ ] Add something to the core
[ ] Other, please explain:

What changes did you make? (Give an overview)

Refers #17225

As per #17105 (comment)

Is there anything you'd like reviewers to focus on?

No

@snitin315 snitin315 requested a review from a team as a code owner June 10, 2023 01:45
@eslint-github-bot eslint-github-bot bot added the documentation Relates to ESLint's documentation label Jun 10, 2023
@mdjermanovic mdjermanovic added the accepted There is consensus among the team that this change meets the criteria for inclusion label Jun 11, 2023
Copy link
Member

@mdjermanovic mdjermanovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@mdjermanovic mdjermanovic merged commit 0e9980c into main Jun 11, 2023
17 checks passed
@mdjermanovic mdjermanovic deleted the docs/semi-omitLastInOneLineClassBody branch June 11, 2023 15:10
@mdjermanovic mdjermanovic restored the docs/semi-omitLastInOneLineClassBody branch June 11, 2023 15:10
@mdjermanovic mdjermanovic deleted the docs/semi-omitLastInOneLineClassBody branch June 11, 2023 15:11
@eslint-github-bot eslint-github-bot bot locked and limited conversation to collaborators Dec 9, 2023
@eslint-github-bot eslint-github-bot bot added the archived due to age This issue has been archived; please open a new issue for any further discussion label Dec 9, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
accepted There is consensus among the team that this change meets the criteria for inclusion archived due to age This issue has been archived; please open a new issue for any further discussion documentation Relates to ESLint's documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants