Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add cwd to rule context #17106

Merged
merged 5 commits into from Apr 29, 2023
Merged

feat: add cwd to rule context #17106

merged 5 commits into from Apr 29, 2023

Conversation

snitin315
Copy link
Contributor

Prerequisites checklist

What is the purpose of this pull request? (put an "X" next to an item)

[x] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofix to a rule
[ ] Add a CLI option
[ ] Add something to the core
[ ] Other, please explain:

What changes did you make? (Give an overview)

Refers #16999

This PR creates context.cwd and deprecates context.getCwd().

Is there anything you'd like reviewers to focus on?

Did I miss any references?

@snitin315 snitin315 requested a review from a team as a code owner April 22, 2023 14:51
@eslint-github-bot eslint-github-bot bot added the feature This change adds a new feature to ESLint label Apr 22, 2023
@netlify
Copy link

netlify bot commented Apr 22, 2023 •
edited

✅ Deploy Preview for docs-eslint ready!

Name Link
🔨 Latest commit 108e149
🔍 Latest deploy log https://app.netlify.com/sites/docs-eslint/deploys/644c792c997d9c000852dfaa
😎 Deploy Preview https://deploy-preview-17106--docs-eslint.netlify.app/extend/custom-rules
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@snitin315 snitin315 mentioned this pull request Apr 22, 2023
Open
39 tasks
fasttime
fasttime reviewed Apr 27, 2023
View reviewed changes
docs/src/extend/custom-rules.md Outdated Show resolved Hide resolved
docs/src/integrate/nodejs-api.md Outdated Show resolved Hide resolved
docs/src/integrate/nodejs-api.md Outdated Show resolved Hide resolved
tests/lib/linter/linter.js Show resolved Hide resolved
@snitin315 snitin315 added the accepted There is consensus among the team that this change meets the criteria for inclusion label Apr 29, 2023
fasttime
fasttime approved these changes Apr 29, 2023
View reviewed changes
Copy link
Member

@fasttime fasttime left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

mdjermanovic
mdjermanovic approved these changes Apr 29, 2023
View reviewed changes
Copy link
Member

@mdjermanovic mdjermanovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@mdjermanovic mdjermanovic merged commit 0df4d4f into main Apr 29, 2023
22 checks passed
@mdjermanovic mdjermanovic deleted the feat/context-cwd branch April 29, 2023 08:53
@mdjermanovic mdjermanovic mentioned this pull request May 27, 2023
Closed
aladdin-add added a commit to aladdin-add/eslint that referenced this pull request Jun 15, 2023
@aladdin-add
docs: resubmit pr17106 doc changes
a7581c9 
credits: https://github.com/snitin315

Refs:
* eslint#17225
* eslint#17106
@aladdin-add aladdin-add mentioned this pull request Jun 15, 2023
Closed
1 task
@snitin315 snitin315 mentioned this pull request Jun 15, 2023
Closed
1 task
aladdin-add added a commit to aladdin-add/eslint that referenced this pull request Jun 15, 2023
@aladdin-add
docs: resubmit custom-rules doc changes
b2a5ec7 
credits: https://github.com/snitin315

Refs:
* eslint#17225
* eslint#17108
* eslint#17106
* eslint#17111
* eslint#17107
aladdin-add added a commit to aladdin-add/eslint that referenced this pull request Jun 15, 2023
@aladdin-add
docs: resubmit custom-rules doc changes
4571154 
credits: https://github.com/snitin315

Refs:
* eslint#17225
* eslint#17108
* eslint#17106
* eslint#17111
* eslint#17107
aladdin-add added a commit to aladdin-add/eslint that referenced this pull request Jun 15, 2023
@aladdin-add
docs: resubmit custom-rules doc changes
36f049d 
credits: https://github.com/snitin315

Refs:
* eslint#17225
* eslint#17108
* eslint#17106
* eslint#17111
* eslint#17107
@aladdin-add aladdin-add mentioned this pull request Jun 15, 2023
Merged
1 task
snitin315 pushed a commit that referenced this pull request Jun 16, 2023
@aladdin-add
docs: resubmit custom-rules doc changes (#17294)
67e7af3 
credits: https://github.com/snitin315

Refs:
* #17225
* #17108
* #17106
* #17111
* #17107
@eslint-github-bot eslint-github-bot bot locked and limited conversation to collaborators Oct 27, 2023
@eslint-github-bot eslint-github-bot bot added the archived due to age This issue has been archived; please open a new issue for any further discussion label Oct 27, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@fasttime fasttime fasttime approved these changes

@mdjermanovic mdjermanovic mdjermanovic approved these changes

Assignees
No one assigned
Labels
accepted There is consensus among the team that this change meets the criteria for inclusion archived due to age This issue has been archived; please open a new issue for any further discussion feature This change adds a new feature to ESLint
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@snitin315 @fasttime @mdjermanovic