Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: resubmit pr17107 doc changes #17290

Closed
wants to merge 1 commit into from

Conversation

aladdin-add
Copy link
Member

credits: https://github.com/snitin315

Refs:

Prerequisites checklist

What is the purpose of this pull request? (put an "X" next to an item)

[ ] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofix to a rule
[ ] Add a CLI option
[ ] Add something to the core
[ ] Other, please explain:

What changes did you make? (Give an overview)

Is there anything you'd like reviewers to focus on?

@aladdin-add aladdin-add requested a review from a team as a code owner June 15, 2023 08:34
@eslint-github-bot eslint-github-bot bot added the documentation Relates to ESLint's documentation label Jun 15, 2023
@snitin315
Copy link
Contributor

@aladdin-add Thanks for the PR. I think we can club changes from the following PRs into one PR to avoid conflicts and rebasing individual PRs.

@mdjermanovic
Copy link
Member

I'm also not sure if git-cherrypicking commits from the period when there was the license issue is the correct way to go. For a cleaner history, it might be better to just create a new unrelated commit with copy-pasted changes.

@aladdin-add
Copy link
Member Author

fine, will recommit it later.

@aladdin-add
Copy link
Member Author

closing in favor of #17294.

@eslint-github-bot eslint-github-bot bot locked and limited conversation to collaborators Dec 13, 2023
@eslint-github-bot eslint-github-bot bot added the archived due to age This issue has been archived; please open a new issue for any further discussion label Dec 13, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
archived due to age This issue has been archived; please open a new issue for any further discussion documentation Relates to ESLint's documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants