Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: move jsdoc settings to eslint-config-eslint #17338

Merged
merged 1 commit into from Jul 4, 2023

Conversation

aladdin-add
Copy link
Member

Prerequisites checklist

What is the purpose of this pull request? (put an "X" next to an item)

[ ] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofix to a rule
[ ] Add a CLI option
[ ] Add something to the core
[ x] Other, please explain:

What changes did you make? (Give an overview)

moving jsdoc settings to eslint-config-eslint, so it's not needed to add it in other repos.

Is there anything you'd like reviewers to focus on?

@aladdin-add aladdin-add requested a review from a team as a code owner July 4, 2023 05:56
@eslint-github-bot eslint-github-bot bot added the chore This change is not user-facing label Jul 4, 2023
@netlify
Copy link

netlify bot commented Jul 4, 2023

Deploy Preview for docs-eslint canceled.

Name Link
🔨 Latest commit 36c66a0
🔍 Latest deploy log https://app.netlify.com/sites/docs-eslint/deploys/64a3b48310d58d000898ac0f

@netlify
Copy link

netlify bot commented Jul 4, 2023

Deploy Preview for docs-eslint canceled.

Name Link
🔨 Latest commit e243919
🔍 Latest deploy log https://app.netlify.com/sites/docs-eslint/deploys/64a3b4865e17b10008de050d

@mdjermanovic mdjermanovic added the accepted There is consensus among the team that this change meets the criteria for inclusion label Jul 4, 2023
Copy link
Member

@mdjermanovic mdjermanovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@mdjermanovic mdjermanovic merged commit 0052374 into eslint:main Jul 4, 2023
22 checks passed
@eslint-github-bot eslint-github-bot bot locked and limited conversation to collaborators Jan 1, 2024
@eslint-github-bot eslint-github-bot bot added the archived due to age This issue has been archived; please open a new issue for any further discussion label Jan 1, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
accepted There is consensus among the team that this change meets the criteria for inclusion archived due to age This issue has been archived; please open a new issue for any further discussion chore This change is not user-facing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants