Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: move jsdoc settings to eslint-config-eslint #17338

Merged
merged 1 commit into from Jul 4, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
10 changes: 0 additions & 10 deletions .eslintrc.js
Expand Up @@ -67,16 +67,6 @@ module.exports = {
parserOptions: {
ecmaVersion: 2021
},

/*
* it fixes eslint-plugin-jsdoc's reports: "Invalid JSDoc tag name "template" jsdoc/check-tag-names"
* refs: https://github.com/gajus/eslint-plugin-jsdoc#check-tag-names
*/
settings: {
jsdoc: {
mode: "typescript"
}
},
rules: {
"internal-rules/multiline-comment-style": "error"
},
Expand Down
10 changes: 0 additions & 10 deletions eslint.config.js
Expand Up @@ -100,16 +100,6 @@ module.exports = [
languageOptions: {
ecmaVersion: "latest"
},

/*
* it fixes eslint-plugin-jsdoc's reports: "Invalid JSDoc tag name "template" jsdoc/check-tag-names"
* refs: https://github.com/gajus/eslint-plugin-jsdoc#check-tag-names
*/
settings: {
jsdoc: {
mode: "typescript"
}
},
rules: {
"internal-rules/multiline-comment-style": "error"
}
Expand Down
1 change: 1 addition & 0 deletions packages/eslint-config-eslint/eslintrc.js
Expand Up @@ -18,6 +18,7 @@ module.exports = {
plugins: ["unicorn"],
settings: {
jsdoc: {
mode: "typescript",
tagNamePreference: {
file: "fileoverview",
augments: "extends",
Expand Down
1 change: 1 addition & 0 deletions packages/eslint-config-eslint/index.js
Expand Up @@ -278,6 +278,7 @@ const jsConfigs = [js.configs.recommended, {
const jsdocConfigs = [jsdoc.configs.recommended, {
settings: {
jsdoc: {
mode: "typescript",
tagNamePreference: {
file: "fileoverview",
augments: "extends",
Expand Down