feat: no-invalid-regexp support v flag
#17404
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for docs-eslint canceled.
|
mdjermanovic
added
rule
|
@ota-meshi can you also update package.json with |
|
I updated regexpp 👍 |
|
Thank you for checking this PR! I added test cases. |
ota-meshi
commented
Jul 23, 2023
tests/lib/rules/no-invalid-regexp.js
Outdated
| code: "new RegExp('[[]\\\\u{0}*' /* valid only with `u` flag */, 'v')", | ||
| errors: [{ | ||
| messageId: "regexMessage", | ||
| data: { message: "Invalid regular expression: /[[]\\u{0}*/u: Unterminated character class" }, |
There was a problem hiding this comment.
I noticed that the error message issued by regexpp was wrong. i will fix the error message.
There was a problem hiding this comment.
Okay, waiting for the fix then. Otherwise, this LGTM.
There was a problem hiding this comment.
I fixed the error message.
1a775c4
1 task
nzakas
approved these changes
Jul 24, 2023
There was a problem hiding this comment.
LGTM. Just waiting for @mdjermanovic to verify his changes.
eslint-github-bot
bot
added
the
archived due to age
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prerequisites checklist
What is the purpose of this pull request? (put an "X" next to an item)
[X] Changes an existing rule (template)
[X] Other, please explain:
Update
@eslint-community/regexppto v4.6.0What changes did you make? (Give an overview)
Refs #17223
This PR modifies the
no-invalid-regexprule and adds support for regexpvflag.Is there anything you'd like reviewers to focus on?