feat: no-control-regex support v flag

[ota-meshi]

Prerequisites checklist

• I have read the contributing guidelines.

What is the purpose of this pull request? (put an "X" next to an item)

[X] Changes an existing rule (template)

What changes did you make? (Give an overview)

Refs #17223

This PR modifies the no-control-regex rule and adds support for regexp v flag.

Is there anything you'd like reviewers to focus on?

[netlify]

✅ Deploy Preview for docs-eslint canceled.

Name	Link
🔨 Latest commit	89f418f
🔍 Latest deploy log	https://app.netlify.com/sites/docs-eslint/deploys/64c0605b7cc456000802451f

[nzakas]

Code LGTM. Can we add in some more tests that use regex literals, too?

[ota-meshi]

Thank you for reviewing this PR. I added two testcases. Could you please check again?

[nzakas]

LGTM, thanks! Would like @mdjermanovic to verify before merging.

[mdjermanovic]

Some weird behavior with "uv":

/* eslint no-control-regex: ["error"] */

/\x11/; // error: Unexpected control character(s) in regular expression: \x11.

RegExp("", "uv"); // error: Unexpected control character(s) in regular expression: \x11.

I'm guessing this happens because in this case validatePattern throws before onPatternEnter is called, so moving this._controlChars = []; into collectControlChars might help (though I'm not sure why it wasn't already there, i.e. is there a reason why onPatternEnter was used for this?).

[ota-meshi]

Thank you for finding the bug!

I added this._controlChars = [] to collectControlChars.
However, I left the onPatternEnter. I added a comment as to why. Could you please check that?

        /*
         * `RegExpValidator` may parse the pattern twice in one `validatePattern`.
         * So `this._controlChars` should be cleared here as well.
         *
         * For example, the `/(?<a>\x1f)/` regex will parse the pattern twice.
         * This is based on the content described in Annex B.
         * If the regex contains a `GroupName` and the `u` flag is not used, `ParseText` will be called twice.
         * See https://tc39.es/ecma262/2023/multipage/additional-ecmascript-features-for-web-browsers.html#sec-parsepattern-annexb
         */

[mdjermanovic]

Thanks for the explanation, very useful! I hadn't thought of that.

[mdjermanovic]

LGTM, thanks!