feat: no-empty-character-class
support v
flag
#17419
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prerequisites checklist
What is the purpose of this pull request? (put an "X" next to an item)
[ ] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[x] Changes an existing rule (template)
[ ] Add autofix to a rule
[ ] Add a CLI option
[ ] Add something to the core
[ ] Other, please explain:
Refs #17223
Updates
no-empty-character-class
to report nested empty character classes.What changes did you make? (Give an overview)
Before this change, this rule was reporting some but not all empty nested character classes, depending on how its own parsing happened to work with the new syntax. Since the syntax becomes too complicated for analyzing patterns with a regex, I switched the rule to use
regexpp
. For performance reasons, I also added a quick search for[]
to exit early and avoid parsing.Is there anything you'd like reviewers to focus on?
Does reporting nested character classes makes sense for this rule? I don't think there's a case where an empty nested character class can be useful.
Note: Allowing empty
[^]
is existing behavior, it was just undocumented and untested.