Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Account for comments in implicit-arrow-linebreak #10545

Merged
merged 27 commits into from Dec 22, 2018
Merged

Fix: Account for comments in implicit-arrow-linebreak #10545

merged 27 commits into from Dec 22, 2018

Commits on Jun 29, 2018

  1. Add and pass for a test case for when a comment exists between an arr… 

    …ow and expression body in implicit-arrow-linebreak
    dios committed Jun 29, 2018
    Copy the full SHA
    4495482 View commit details
    Browse the repository at this point in the history

Commits on Jul 10, 2018

  1. Fix formatting

    @peanutenthusiast
    dios authored and peanutenthusiast committed Jul 10, 2018
    Copy the full SHA
    7b9bdf4 View commit details
    Browse the repository at this point in the history

  2. Add and pass test case for when arrow expression is set to variable

    @peanutenthusiast
    dios authored and peanutenthusiast committed Jul 10, 2018
    Copy the full SHA
    fd31e18 View commit details
    Browse the repository at this point in the history

  3. Add test cases for when comments exist within parens enwrapped arrow … 

    …function bodies, pass cases
    @peanutenthusiast
    dios authored and peanutenthusiast committed Jul 10, 2018
    Copy the full SHA
    1d216a5 View commit details
    Browse the repository at this point in the history

  4. Add test cases for block comments, multiple comments within an arrow … 

    …expression, pass test cases, create helper for formatting comments
    @peanutenthusiast
    dios authored and peanutenthusiast committed Jul 10, 2018
    Copy the full SHA
    f1d6e09 View commit details
    Browse the repository at this point in the history

  5. Add a test case to ensure filtering of comments between start of arro… 

    …w expression and parens
    @peanutenthusiast
    dios authored and peanutenthusiast committed Jul 10, 2018
    Copy the full SHA
    41f3ec4 View commit details
    Browse the repository at this point in the history

  6. Change condition to check for length of comment text length

    @peanutenthusiast
    dios authored and peanutenthusiast committed Jul 10, 2018
    Copy the full SHA
    b418604 View commit details
    Browse the repository at this point in the history

  7. Condense logic for comments filtering

    @peanutenthusiast
    dios authored and peanutenthusiast committed Jul 10, 2018
    Copy the full SHA
    1f03b18 View commit details
    Browse the repository at this point in the history

  8. Reword documentation for helper function

    @peanutenthusiast
    dios authored and peanutenthusiast committed Jul 10, 2018
    Copy the full SHA
    d1f1a43 View commit details
    Browse the repository at this point in the history

  9. Account for multi arrow function test case with comments for implicit… 

    …-arrow-linebreak, begin implementation for condition
    @peanutenthusiast
    dios authored and peanutenthusiast committed Jul 10, 2018
    Copy the full SHA
    e6098d1 View commit details
    Browse the repository at this point in the history

  10. Add test case for when some arrow function bodies are wrapped with pa… 

    …rens, add logic to account for test case
    @peanutenthusiast
    dios authored and peanutenthusiast committed Jul 10, 2018
    Copy the full SHA
    7ddaa0c View commit details
    Browse the repository at this point in the history

  11. Export fixer logic for besides to autoFixBesides function, account fo… 

    …r test cases with nested arrow functions, specify astutil functions in implicit arrow linebreak
    @peanutenthusiast
    dios authored and peanutenthusiast committed Jul 10, 2018
    Copy the full SHA
    5d63f71 View commit details
    Browse the repository at this point in the history

  12. REmove extra semicolon from top

    @peanutenthusiast
    dios authored and peanutenthusiast committed Jul 10, 2018
    Copy the full SHA
    706a48e View commit details
    Browse the repository at this point in the history

  13. Add test cases for async arrow functions, method chains, object liter… 

    …als, add parameter and documentation for column for formatComments, add findFirstToken helper
    @peanutenthusiast
    dios authored and peanutenthusiast committed Jul 10, 2018
    Copy the full SHA
    089310a View commit details
    Browse the repository at this point in the history

Commits on Jul 11, 2018

  1. Fix lines for cherry-pick

    @peanutenthusiast
    peanutenthusiast committed Jul 11, 2018
    Copy the full SHA
    d50c95f View commit details
    Browse the repository at this point in the history

  2. Remove line

    @peanutenthusiast
    peanutenthusiast committed Jul 11, 2018
    Copy the full SHA
    2daf6c9 View commit details
    Browse the repository at this point in the history

  3. Rename fixerTarget to arrowBody for autoFixBesides and addParentheses… 

    … functions
    @peanutenthusiast
    peanutenthusiast committed Jul 11, 2018
    Copy the full SHA
    f52d5d5 View commit details
    Browse the repository at this point in the history

Commits on Aug 22, 2018

  1. Add valid test cases

    dios committed Aug 22, 2018
    Copy the full SHA
    4ee9ac5 View commit details
    Browse the repository at this point in the history

  2. Account for promise constructor and callback test cases

    dios committed Aug 22, 2018
    Copy the full SHA
    37bd7a0 View commit details
    Browse the repository at this point in the history

  3. Add test cases for multiline comments

    dios committed Aug 22, 2018
    Copy the full SHA
    157fdec View commit details
    Browse the repository at this point in the history

  4. Remove dangling commas, add comments and extra details to jsdocs for … 

    …clarity
    dios committed Aug 22, 2018
    Copy the full SHA
    9452331 View commit details
    Browse the repository at this point in the history

Commits on Aug 27, 2018

  1. Merge branch 'master' into fix-implicit-arrow-linebreak

    @peanutenthusiast
    peanutenthusiast committed Aug 27, 2018
    Copy the full SHA
    b247f58 View commit details
    Browse the repository at this point in the history

  2. Update branch, fix import statement for ast-utils

    @peanutenthusiast
    peanutenthusiast committed Aug 27, 2018
    Copy the full SHA
    6a2039a View commit details
    Browse the repository at this point in the history

  3. Merge branch 'fix-implicit-arrow-linebreak' of https://github.com/pea… 

    …nutenthusiast/eslint into fix-implicit-arrow-linebreak
    @peanutenthusiast
    peanutenthusiast committed Aug 27, 2018
    Copy the full SHA
    474c39f View commit details
    Browse the repository at this point in the history

Commits on Dec 6, 2018

  1. Apply requested change to string template for tests on lines 258 and 269

    dios committed Dec 6, 2018
    Copy the full SHA
    388db16 View commit details
    Browse the repository at this point in the history

Commits on Dec 18, 2018

  1. Merge branch 'master' into updated

    dios committed Dec 18, 2018
    Copy the full SHA
    26635d6 View commit details
    Browse the repository at this point in the history

  2. Add and pass test cases for variable declarations with multiple decla… 

    …rations
    dios committed Dec 18, 2018
    Copy the full SHA
    65a7b61 View commit details
    Browse the repository at this point in the history