New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update: add ignoreDestructuring
option to id-match
rule
#10554
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR!
One question: What is the current behavior of renamed and non-renamed import specifiers, and the intended behavior of the same after this pull request? (I'm wondering if we should have another option for import specifiers that works similarly for renamed import specifiers, maybe as a separate PR.)
66eee77
to
dff1a1c
Compare
@platinumazure I've recommitted, would you mind review again to see if there's any more problems should be fixed? Thanks a lot! :-) |
202ac79
to
0001128
Compare
Hi @tinymins, very sorry for losing track of this. I'll champion this issue. (Will hopefully work with the ESLint team to accept this issue soon!) I'll review this over the weekend! |
@platinumazure Thanks, with any problem in this PR, just point it out here, I'll check Github email everyday. |
73a390d
to
68e7f95
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks! just need one more 👍 to accept it. /cc @eslint/eslint-team
68e7f95
to
64d2e39
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks @tinymins!
Thanks @tinymins. Sorry it took so long to merge this in, but we really appreciate your work. |
Thanks again for review and merge this! |
What is the purpose of this pull request? (put an "X" next to item)
[ ] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[x] Changes an existing rule (template)
[ ] Add autofixing to a rule
[ ] Add a CLI option
[ ] Add something to the core
[ ] Other, please explain:
What changes did you make? (Give an overview)
add
ignoreDestructuring
option toid-match
ruleIs there anything you'd like reviewers to focus on?
Nope.
Sorry that I do this code split job so late, cause I caught a cold and fever last week.