Chore: enable no-prototype-builtins in codebase (fixes #10660) #10664
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aladdin-add
added
evaluating
|
I'm in favor of the idea, but there are a lot of existing use cases in the codebase that would need to be fixed before we can enable the rule. |
|
will fix it asap! |
aladdin-add
force-pushed
the
Aladdin-ADD-patch-2
branch
from
4a9e825
to
33351ff
Compare
ilyavolodin
reviewed
Aug 4, 2018
There was a problem hiding this comment.
I would rather see Object.prototype.hasOwnProperty inlined everywhere, instead of creating a temp variable with {}.hasOwnProperty. To me it's less confusing and more readable when it's inlined and when it's not using shorthand. I don't feel very strongly about it, but would prefer it.
|
Agreed with @ilyavolodin. |
aladdin-add
force-pushed
the
Aladdin-ADD-patch-2
branch
3 times, most recently
from
2ca214e
to
c841b29
Compare
platinumazure
approved these changes
Aug 10, 2018
kaicataldo
approved these changes
Aug 10, 2018
|
If we add a unit test as suggested in #10711, can we close the issue this is referencing in this PR? I ask because it looks like the other PR has stalled. |
aladdin-add
force-pushed
the
Aladdin-ADD-patch-2
branch
from
812f31f
to
0117d32
Compare
aladdin-add
changed the title
eslint-deprecated
bot
added
the
archived due to age
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refs #10660
What is the purpose of this pull request? (put an "X" next to item)
[ ] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofixing to a rule
[ ] Add a CLI option
[ ] Add something to the core
[x] Other, please explain:
What changes did you make? (Give an overview)
Is there anything you'd like reviewers to focus on?
Do we want a way to find which rules can be enabled(to see if there's similar problems)?