Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update: space-infix-ops reports violating operator #10934

Merged
merged 1 commit into from Dec 8, 2018
Merged

Update: space-infix-ops reports violating operator #10934

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
5 changes: 4 additions & 1 deletion lib/rules/space-infix-ops.js
View file
Open in desktop
Expand Up @@ -79,7 +79,10 @@ module.exports = {
context.report({
node: mainNode,
loc: culpritToken.loc.start,
message: "Infix operators must be spaced.",
message: "Operator '{{operator}}' must be spaced.",
data: {
operator: culpritToken.value
},
fix(fixer) {
const previousToken = sourceCode.getTokenBefore(culpritToken);
const afterToken = sourceCode.getTokenAfter(culpritToken);
Expand Down
66 changes: 33 additions & 33 deletions tests/lib/rules/space-infix-ops.js
View file
Open in desktop
Expand Up @@ -45,7 +45,7 @@ ruleTester.run("space-infix-ops", rule, {
code: "a+b",
output: "a + b",
errors: [{
message: "Infix operators must be spaced.",
message: "Operator '+' must be spaced.",
type: "BinaryExpression",
line: 1,
column: 2
Expand All @@ -55,7 +55,7 @@ ruleTester.run("space-infix-ops", rule, {
code: "a +b",
output: "a + b",
errors: [{
message: "Infix operators must be spaced.",
message: "Operator '+' must be spaced.",
type: "BinaryExpression",
line: 1,
column: 3
Expand All @@ -65,7 +65,7 @@ ruleTester.run("space-infix-ops", rule, {
code: "a+ b",
output: "a + b",
errors: [{
message: "Infix operators must be spaced.",
message: "Operator '+' must be spaced.",
type: "BinaryExpression",
line: 1,
column: 2
Expand All @@ -75,7 +75,7 @@ ruleTester.run("space-infix-ops", rule, {
code: "a||b",
output: "a || b",
errors: [{
message: "Infix operators must be spaced.",
message: "Operator '||' must be spaced.",
type: "LogicalExpression",
line: 1,
column: 2
Expand All @@ -85,7 +85,7 @@ ruleTester.run("space-infix-ops", rule, {
code: "a ||b",
output: "a || b",
errors: [{
message: "Infix operators must be spaced.",
message: "Operator '||' must be spaced.",
type: "LogicalExpression",
line: 1,
column: 3
Expand All @@ -95,7 +95,7 @@ ruleTester.run("space-infix-ops", rule, {
code: "a|| b",
output: "a || b",
errors: [{
message: "Infix operators must be spaced.",
message: "Operator '||' must be spaced.",
type: "LogicalExpression",
line: 1,
column: 2
Expand All @@ -105,7 +105,7 @@ ruleTester.run("space-infix-ops", rule, {
code: "a=b",
output: "a = b",
errors: [{
message: "Infix operators must be spaced.",
message: "Operator '=' must be spaced.",
type: "AssignmentExpression",
line: 1,
column: 2
Expand All @@ -115,7 +115,7 @@ ruleTester.run("space-infix-ops", rule, {
code: "a= b",
output: "a = b",
errors: [{
message: "Infix operators must be spaced.",
message: "Operator '=' must be spaced.",
type: "AssignmentExpression",
line: 1,
column: 2
Expand All @@ -125,7 +125,7 @@ ruleTester.run("space-infix-ops", rule, {
code: "a =b",
output: "a = b",
errors: [{
message: "Infix operators must be spaced.",
message: "Operator '=' must be spaced.",
type: "AssignmentExpression",
line: 1,
column: 3
Expand All @@ -135,7 +135,7 @@ ruleTester.run("space-infix-ops", rule, {
code: "a?b:c",
output: "a ? b:c",
errors: [{
message: "Infix operators must be spaced.",
message: "Operator '?' must be spaced.",
type: "ConditionalExpression",
line: 1,
column: 2
Expand All @@ -145,7 +145,7 @@ ruleTester.run("space-infix-ops", rule, {
code: "a?b : c",
output: "a ? b : c",
errors: [{
message: "Infix operators must be spaced.",
message: "Operator '?' must be spaced.",
type: "ConditionalExpression",
line: 1,
column: 2
Expand All @@ -155,7 +155,7 @@ ruleTester.run("space-infix-ops", rule, {
code: "a ? b:c",
output: "a ? b : c",
errors: [{
message: "Infix operators must be spaced.",
message: "Operator ':' must be spaced.",
type: "ConditionalExpression",
line: 1,
column: 6
Expand All @@ -165,7 +165,7 @@ ruleTester.run("space-infix-ops", rule, {
code: "a? b : c",
output: "a ? b : c",
errors: [{
message: "Infix operators must be spaced.",
message: "Operator '?' must be spaced.",
type: "ConditionalExpression",
line: 1,
column: 2
Expand All @@ -175,7 +175,7 @@ ruleTester.run("space-infix-ops", rule, {
code: "a ?b : c",
output: "a ? b : c",
errors: [{
message: "Infix operators must be spaced.",
message: "Operator '?' must be spaced.",
type: "ConditionalExpression",
line: 1,
column: 3
Expand All @@ -185,7 +185,7 @@ ruleTester.run("space-infix-ops", rule, {
code: "a ? b: c",
output: "a ? b : c",
errors: [{
message: "Infix operators must be spaced.",
message: "Operator ':' must be spaced.",
type: "ConditionalExpression",
line: 1,
column: 6
Expand All @@ -195,7 +195,7 @@ ruleTester.run("space-infix-ops", rule, {
code: "a ? b :c",
output: "a ? b : c",
errors: [{
message: "Infix operators must be spaced.",
message: "Operator ':' must be spaced.",
type: "ConditionalExpression",
line: 1,
column: 7
Expand All @@ -205,7 +205,7 @@ ruleTester.run("space-infix-ops", rule, {
code: "var a=b;",
output: "var a = b;",
errors: [{
message: "Infix operators must be spaced.",
message: "Operator '=' must be spaced.",
type: "VariableDeclarator",
line: 1,
column: 6
Expand All @@ -215,7 +215,7 @@ ruleTester.run("space-infix-ops", rule, {
code: "var a= b;",
output: "var a = b;",
errors: [{
message: "Infix operators must be spaced.",
message: "Operator '=' must be spaced.",
type: "VariableDeclarator",
line: 1,
column: 6
Expand All @@ -225,7 +225,7 @@ ruleTester.run("space-infix-ops", rule, {
code: "var a =b;",
output: "var a = b;",
errors: [{
message: "Infix operators must be spaced.",
message: "Operator '=' must be spaced.",
type: "VariableDeclarator",
line: 1,
column: 7
Expand All @@ -235,7 +235,7 @@ ruleTester.run("space-infix-ops", rule, {
code: "var a = b, c=d;",
output: "var a = b, c = d;",
errors: [{
message: "Infix operators must be spaced.",
message: "Operator '=' must be spaced.",
type: "VariableDeclarator",
line: 1,
column: 13
Expand All @@ -248,7 +248,7 @@ ruleTester.run("space-infix-ops", rule, {
int32Hint: true
}],
errors: [{
message: "Infix operators must be spaced.",
message: "Operator '|' must be spaced.",
type: "BinaryExpression",
line: 1,
column: 2
Expand All @@ -258,7 +258,7 @@ ruleTester.run("space-infix-ops", rule, {
code: "var output = test || (test && test.value) ||(test2 && test2.value);",
output: "var output = test || (test && test.value) || (test2 && test2.value);",
errors: [{
message: "Infix operators must be spaced.",
message: "Operator '||' must be spaced.",
type: "LogicalExpression",
line: 1,
column: 43
Expand All @@ -268,7 +268,7 @@ ruleTester.run("space-infix-ops", rule, {
code: "var output = a ||(b && c.value) || (d && e.value);",
output: "var output = a || (b && c.value) || (d && e.value);",
errors: [{
message: "Infix operators must be spaced.",
message: "Operator '||' must be spaced.",
type: "LogicalExpression",
line: 1,
column: 16
Expand All @@ -278,7 +278,7 @@ ruleTester.run("space-infix-ops", rule, {
code: "var output = a|| (b && c.value) || (d && e.value);",
output: "var output = a || (b && c.value) || (d && e.value);",
errors: [{
message: "Infix operators must be spaced.",
message: "Operator '||' must be spaced.",
type: "LogicalExpression",
line: 1,
column: 15
Expand All @@ -289,7 +289,7 @@ ruleTester.run("space-infix-ops", rule, {
output: "const my_object = {key: 'value'}",
parserOptions: { ecmaVersion: 6 },
errors: [{
message: "Infix operators must be spaced.",
message: "Operator '=' must be spaced.",
type: "VariableDeclarator",
line: 1,
column: 16
Expand All @@ -300,12 +300,12 @@ ruleTester.run("space-infix-ops", rule, {
output: "var {a = 0} = bar;",
parserOptions: { ecmaVersion: 6 },
errors: [{
message: "Infix operators must be spaced.",
message: "Operator '=' must be spaced.",
line: 1,
column: 7,
nodeType: "AssignmentPattern"
}, {
message: "Infix operators must be spaced.",
message: "Operator '=' must be spaced.",
line: 1,
column: 10,
nodeType: "VariableDeclarator"
Expand All @@ -316,7 +316,7 @@ ruleTester.run("space-infix-ops", rule, {
output: "function foo(a = 0) { }",
parserOptions: { ecmaVersion: 6 },
errors: [{
message: "Infix operators must be spaced.",
message: "Operator '=' must be spaced.",
line: 1,
column: 15,
nodeType: "AssignmentPattern"
Expand All @@ -327,7 +327,7 @@ ruleTester.run("space-infix-ops", rule, {
output: "a ** b",
parserOptions: { ecmaVersion: 7 },
errors: [{
message: "Infix operators must be spaced.",
message: "Operator '**' must be spaced.",
line: 1,
column: 2,
nodeType: "BinaryExpression"
Expand All @@ -337,7 +337,7 @@ ruleTester.run("space-infix-ops", rule, {
code: "'foo'in{}",
output: "'foo' in {}",
errors: [{
message: "Infix operators must be spaced.",
message: "Operator 'in' must be spaced.",
line: 1,
column: 6,
nodeType: "BinaryExpression"
Expand All @@ -347,7 +347,7 @@ ruleTester.run("space-infix-ops", rule, {
code: "'foo'instanceof{}",
output: "'foo' instanceof {}",
errors: [{
message: "Infix operators must be spaced.",
message: "Operator 'instanceof' must be spaced.",
line: 1,
column: 6,
nodeType: "BinaryExpression"
Expand All @@ -360,7 +360,7 @@ ruleTester.run("space-infix-ops", rule, {
code: "var a: Foo= b;",
output: "var a: Foo = b;",
errors: [{
message: "Infix operators must be spaced.",
message: "Operator '=' must be spaced.",
type: "VariableDeclarator",
line: 1,
column: 11
Expand All @@ -372,7 +372,7 @@ ruleTester.run("space-infix-ops", rule, {
output: "function foo(a: number = 0): Foo { }",
parserOptions: { ecmaVersion: 6 },
errors: [{
message: "Infix operators must be spaced.",
message: "Operator '=' must be spaced.",
line: 1,
column: 23,
nodeType: "AssignmentPattern"
Expand Down