Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: allow leading semi in next line (fixes #11082) #11085

Merged
merged 1 commit into from Nov 18, 2018
Merged

Fix: allow leading semi in next line (fixes #11082) #11085

merged 1 commit into from Nov 18, 2018

Conversation

g-plane
Copy link
Member

@g-plane g-plane commented Nov 15, 2018

What is the purpose of this pull request? (put an "X" next to item)

[x] Bug fix

What changes did you make? (Give an overview)
Fix #11082

@eslint-deprecated eslint-deprecated bot added the triage An ESLint team member will look at this issue soon label Nov 15, 2018
@kaicataldo kaicataldo added bug ESLint is working incorrectly rule Relates to ESLint's core rules accepted There is consensus among the team that this change meets the criteria for inclusion indent Relates to the `indent` rule and removed triage An ESLint team member will look at this issue soon labels Nov 15, 2018
not-an-aardvark
not-an-aardvark approved these changes Nov 18, 2018
View reviewed changes
Copy link
Member

@not-an-aardvark not-an-aardvark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@not-an-aardvark not-an-aardvark merged commit 3025cdd into eslint:master Nov 18, 2018
@g-plane g-plane deleted the fix-11082 branch November 19, 2018 02:55
@kjg kjg mentioned this pull request Feb 11, 2019
Closed
@eslint-deprecated eslint-deprecated bot locked and limited conversation to collaborators May 18, 2019
@eslint-deprecated eslint-deprecated bot added the archived due to age This issue has been archived; please open a new issue for any further discussion label May 18, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@not-an-aardvark not-an-aardvark not-an-aardvark approved these changes

Assignees
No one assigned
Labels
accepted There is consensus among the team that this change meets the criteria for inclusion archived due to age This issue has been archived; please open a new issue for any further discussion bug ESLint is working incorrectly indent Relates to the `indent` rule rule Relates to ESLint's core rules
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

IIFE with leading semicolon wants to be intended when directly after imports
3 participants
@g-plane @not-an-aardvark @kaicataldo