Chore: enable require-unicode-regexp on ESLint codebase

Makefile.js

@@ -42,7 +42,7 @@ const { cat, cd, cp, echo, exec, exit, find, ls, mkdir, pwd, rm, test } = requir
 const PERF_MULTIPLIER = 13e6;
 
 const OPEN_SOURCE_LICENSES = [
-    /MIT/, /BSD/, /Apache/, /ISC/, /WTF/, /Public Domain/, /LGPL/
+    /MIT/u, /BSD/u, /Apache/u, /ISC/u, /WTF/u, /Public Domain/u, /LGPL/u
 ];
 
 //------------------------------------------------------------------------------
@@ -137,7 +137,7 @@ function generateBlogPost(releaseInfo, prereleaseMajorVersion) {
     const ruleList = ls("lib/rules")
 
         // Strip the .js extension
-        .map(ruleFileName => ruleFileName.replace(/\.js$/, ""))
+        .map(ruleFileName => ruleFileName.replace(/\.js$/u, ""))
 
         /*
          * Sort by length descending. This ensures that rule names which are substrings of other rule names are not
@@ -719,7 +719,7 @@ target.gensite = function(prereleaseVersion) {
             } else {
 
                 // extract the title from the file itself
-                title = text.match(/#([^#].+)\n/);
+                title = text.match(/#([^#].+)\n/u);
                 if (title) {
                     title = title[1].trim();
                 } else {
@@ -740,10 +740,10 @@ target.gensite = function(prereleaseVersion) {
             ].join("\n");
 
             // 6. Remove .md extension for relative links and change README to empty string
-            text = text.replace(/\((?!https?:\/\/)([^)]*?)\.md(.*?)\)/g, "($1$2)").replace("README.html", "");
+            text = text.replace(/\((?!https?:\/\/)([^)]*?)\.md(.*?)\)/gu, "($1$2)").replace("README.html", "");
 
             // 7. Check if there's a trailing white line at the end of the file, if there isn't one, add it
-            if (!/\n$/.test(text)) {
+            if (!/\n$/u.test(text)) {
                 text = `${text}\n`;
             }
 
@@ -847,8 +847,8 @@ target.checkRuleFiles = function() {
          */
         function hasIdInTitle(id) {
             const docText = cat(docFilename);
-            const idOldAtEndOfTitleRegExp = new RegExp(`^# (.*?) \\(${id}\\)`); // original format
-            const idNewAtBeginningOfTitleRegExp = new RegExp(`^# ${id}: `); // new format is same as rules index
+            const idOldAtEndOfTitleRegExp = new RegExp(`^# (.*?) \\(${id}\\)`, "u"); // original format
+            const idNewAtBeginningOfTitleRegExp = new RegExp(`^# ${id}: `, "u"); // new format is same as rules index
             /*
              * 1. Added support for new format.
              * 2. Will remove support for old format after all docs files have new format.

lib/cli-engine.js

@@ -258,7 +258,7 @@ function processFile(filename, configHelper, options, linter) {
  */
 function createIgnoreResult(filePath, baseDir) {
     let message;
-    const isHidden = /^\./.test(path.basename(filePath));
+    const isHidden = /^\./u.test(path.basename(filePath));
     const isInNodeModules = baseDir && path.relative(baseDir, filePath).startsWith("node_modules");
     const isInBowerComponents = baseDir && path.relative(baseDir, filePath).startsWith("bower_components");
 
@@ -757,7 +757,7 @@ class CLIEngine {
         if (typeof resolvedFormatName === "string") {
 
             // replace \ with / for Windows compatibility
-            const normalizedFormatName = resolvedFormatName.replace(/\\/g, "/");
+            const normalizedFormatName = resolvedFormatName.replace(/\\/gu, "/");
 
             const cwd = this.options ? this.options.cwd : process.cwd();
             const namespace = naming.getNamespaceFromTerm(normalizedFormatName);

lib/config/config-file.js

@@ -61,7 +61,7 @@ const resolver = new ModuleResolver();
  * @private
  */
 function readFile(filePath) {
-    return fs.readFileSync(filePath, "utf8").replace(/^\ufeff/, "");
+    return fs.readFileSync(filePath, "utf8").replace(/^\ufeff/u, "");
 }
 
 /**
@@ -73,7 +73,7 @@ function readFile(filePath) {
  * @private
  */
 function isFilePath(filePath) {
-    return path.isAbsolute(filePath) || !/\w|@/.test(filePath.charAt(0));
+    return path.isAbsolute(filePath) || !/\w|@/u.test(filePath.charAt(0));
 }
 
 /**

lib/config/config-initializer.js

@@ -152,7 +152,7 @@ function configureRules(answers, config) {
     bar.tick(0); // Shows the progress bar
 
     // Get the SourceCode of all chosen files
-    const patterns = answers.patterns.split(/[\s]+/);
+    const patterns = answers.patterns.split(/[\s]+/u);
 
     try {
         sourceCodes = getSourceCodeOfFiles(patterns, { baseConfig: newConfig, useEslintrc: false }, total => {

lib/config/config-validator.js

@@ -76,7 +76,7 @@ function validateRuleSeverity(options) {
         return normSeverity;
     }
 
-    throw new Error(`\tSeverity should be one of the following: 0 = off, 1 = warn, 2 = error (you passed '${util.inspect(severity).replace(/'/g, "\"").replace(/\n/g, "")}').\n`);
+    throw new Error(`\tSeverity should be one of the following: 0 = off, 1 = warn, 2 = error (you passed '${util.inspect(severity).replace(/'/gu, "\"").replace(/\n/gu, "")}').\n`);
 
 }
 

lib/config/plugins.js

@@ -84,7 +84,7 @@ class Plugins {
         const shortName = naming.getShorthandName(longName, "eslint-plugin");
         let plugin = null;
 
-        if (pluginName.match(/\s+/)) {
+        if (pluginName.match(/\s+/u)) {
             const whitespaceError = new Error(`Whitespace found in plugin name '${pluginName}'`);
 
             whitespaceError.messageTemplate = "whitespace-found";

lib/formatters/codeframe.js

@@ -47,7 +47,7 @@ function formatFilePath(filePath, line, column) {
  */
 function formatMessage(message, parentResult) {
     const type = (message.fatal || message.severity === 2) ? chalk.red("error") : chalk.yellow("warning");
-    const msg = `${chalk.bold(message.message.replace(/([^ ])\.$/, "$1"))}`;
+    const msg = `${chalk.bold(message.message.replace(/([^ ])\.$/u, "$1"))}`;
     const ruleId = message.fatal ? "" : chalk.dim(`(${message.ruleId})`);
     const filePath = formatFilePath(parentResult.filePath, message.line, message.column);
     const sourceCode = parentResult.output ? parentResult.output : parentResult.source;

lib/formatters/stylish.js

@@ -65,7 +65,7 @@ module.exports = function(results) {
                     message.line || 0,
                     message.column || 0,
                     messageType,
-                    message.message.replace(/([^ ])\.$/, "$1"),
+                    message.message.replace(/([^ ])\.$/u, "$1"),
                     chalk.dim(message.ruleId || "")
                 ];
             }),
@@ -75,7 +75,7 @@ module.exports = function(results) {
                     return stripAnsi(str).length;
                 }
             }
-        ).split("\n").map(el => el.replace(/(\d+)\s+(\d+)/, (m, p1, p2) => chalk.dim(`${p1}:${p2}`))).join("\n")}\n\n`;
+        ).split("\n").map(el => el.replace(/(\d+)\s+(\d+)/u, (m, p1, p2) => chalk.dim(`${p1}:${p2}`))).join("\n")}\n\n`;
     });
 
     const total = errorCount + warningCount;

lib/linter.js

@@ -164,15 +164,15 @@ function getDirectiveComments(filename, ast, ruleMapper) {
 
     ast.comments.filter(token => token.type !== "Shebang").forEach(comment => {
         const trimmedCommentText = comment.value.trim();
-        const match = /^(eslint(-\w+){0,3}|exported|globals?)(\s|$)/.exec(trimmedCommentText);
+        const match = /^(eslint(-\w+){0,3}|exported|globals?)(\s|$)/u.exec(trimmedCommentText);
 
         if (!match) {
             return;
         }
 
         const directiveValue = trimmedCommentText.slice(match.index + match[1].length);
 
-        if (/^eslint-disable-(next-)?line$/.test(match[1])) {
+        if (/^eslint-disable-(next-)?line$/u.test(match[1])) {
             if (comment.loc.start.line === comment.loc.end.line) {
                 const directiveType = match[1].slice("eslint-".length);
 
@@ -276,7 +276,7 @@ function normalizeEcmaVersion(ecmaVersion, isModule) {
     return ecmaVersion;
 }
 
-const eslintEnvPattern = /\/\*\s*eslint-env\s(.+?)\*\//g;
+const eslintEnvPattern = /\/\*\s*eslint-env\s(.+?)\*\//gu;
 
 /**
  * Checks whether or not there is a comment which has "eslint-env *" in a given text.
@@ -498,7 +498,7 @@ function parse(text, providedParserOptions, parserName, parserMap, filePath) {
     } catch (ex) {
 
         // If the message includes a leading line number, strip it:
-        const message = `Parsing error: ${ex.message.replace(/^line \d+:/i, "").trim()}`;
+        const message = `Parsing error: ${ex.message.replace(/^line \d+:/iu, "").trim()}`;
 
         return {
             success: false,

lib/rules/array-callback-return.js

@@ -17,8 +17,8 @@ const astUtils = require("../util/ast-utils");
 // Helpers
 //------------------------------------------------------------------------------
 
-const TARGET_NODE_TYPE = /^(?:Arrow)?FunctionExpression$/;
-const TARGET_METHODS = /^(?:every|filter|find(?:Index)?|map|reduce(?:Right)?|some|sort)$/;
+const TARGET_NODE_TYPE = /^(?:Arrow)?FunctionExpression$/u;
+const TARGET_METHODS = /^(?:every|filter|find(?:Index)?|map|reduce(?:Right)?|some|sort)$/u;
 
 /**
  * Checks a given code path segment is reachable.

lib/rules/arrow-body-style.js

@@ -82,7 +82,7 @@ module.exports = {
          * @returns {boolean} `true` if it changes semantics if `;` or `}` followed by the token are removed.
          */
         function hasASIProblem(token) {
-            return token && token.type === "Punctuator" && /^[([/`+-]/.test(token.value);
+            return token && token.type === "Punctuator" && /^[([/`+-]/u.test(token.value);
         }
 
         /**

lib/rules/camelcase.js

@@ -90,7 +90,7 @@ module.exports = {
          */
         function isAllowed(name) {
             return allow.findIndex(
-                entry => name === entry || name.match(new RegExp(entry))
+                entry => name === entry || name.match(new RegExp(entry)) // eslint-disable-line require-unicode-regexp
             ) !== -1;
         }
 
@@ -142,7 +142,7 @@ module.exports = {
                  * private/protected identifiers, strip them before checking if underscored
                  */
                 const name = node.name,
-                    nameIsUnderscored = isUnderscored(name.replace(/^_+|_+$/g, "")),
+                    nameIsUnderscored = isUnderscored(name.replace(/^_+|_+$/gu, "")),
                     effectiveParent = (node.parent.type === "MemberExpression") ? node.parent.parent : node.parent;
 
                 // First, we ignore the node if it match the ignore list

lib/rules/capitalized-comments.js

@@ -16,8 +16,8 @@ const astUtils = require("../util/ast-utils");
 //------------------------------------------------------------------------------
 
 const DEFAULT_IGNORE_PATTERN = astUtils.COMMENTS_IGNORE_PATTERN,
-    WHITESPACE = /\s/g,
-    MAYBE_URL = /^\s*[^:/?#\s]+:\/\/[^?#]/; // TODO: Combine w/ max-len pattern?
+    WHITESPACE = /\s/gu,
+    MAYBE_URL = /^\s*[^:/?#\s]+:\/\/[^?#]/u; // TODO: Combine w/ max-len pattern?
 
 /*
  * Base schema body for defining the basic capitalization rule, ignorePattern,
@@ -96,7 +96,7 @@ function createRegExpForIgnorePatterns(normalizedOptions) {
         const ignorePatternStr = normalizedOptions[key].ignorePattern;
 
         if (ignorePatternStr) {
-            const regExp = RegExp(`^\\s*(?:${ignorePatternStr})`);
+            const regExp = RegExp(`^\\s*(?:${ignorePatternStr})`); // eslint-disable-line require-unicode-regexp
 
             normalizedOptions[key].ignorePatternRegExp = regExp;
         }
@@ -215,7 +215,7 @@ module.exports = {
 
             // 2. Check for custom ignore pattern.
             const commentWithoutAsterisks = comment.value
-                .replace(/\*/g, "");
+                .replace(/\*/gu, "");
 
             if (options.ignorePatternRegExp && options.ignorePatternRegExp.test(commentWithoutAsterisks)) {
                 return true;

lib/rules/curly.js

@@ -191,7 +191,7 @@ module.exports = {
                 return true;
             }
 
-            if (/^[([/`+-]/.test(tokenAfter.value)) {
+            if (/^[([/`+-]/u.test(tokenAfter.value)) {
 
                 // If the next token starts with a character that would disrupt ASI, insert a semicolon.
                 return true;

lib/rules/default-case.js

@@ -4,7 +4,7 @@
  */
 "use strict";
 
-const DEFAULT_COMMENT_PATTERN = /^no default$/i;
+const DEFAULT_COMMENT_PATTERN = /^no default$/iu;
 
 //------------------------------------------------------------------------------
 // Rule Definition
@@ -39,7 +39,7 @@ module.exports = {
     create(context) {
         const options = context.options[0] || {};
         const commentPattern = options.commentPattern
-            ? new RegExp(options.commentPattern)
+            ? new RegExp(options.commentPattern) // eslint-disable-line require-unicode-regexp
             : DEFAULT_COMMENT_PATTERN;
 
         const sourceCode = context.getSourceCode();

lib/rules/dot-notation.js

@@ -14,7 +14,7 @@ const astUtils = require("../util/ast-utils");
 // Rule Definition
 //------------------------------------------------------------------------------
 
-const validIdentifier = /^[a-zA-Z_$][a-zA-Z0-9_$]*$/;
+const validIdentifier = /^[a-zA-Z_$][a-zA-Z0-9_$]*$/u;
 const keywords = require("../util/keywords");
 
 module.exports = {
@@ -61,7 +61,7 @@ module.exports = {
         let allowPattern;
 
         if (options.allowPattern) {
-            allowPattern = new RegExp(options.allowPattern);
+            allowPattern = new RegExp(options.allowPattern); // eslint-disable-line require-unicode-regexp
         }
 
         /**

lib/rules/eol-last.js

@@ -97,7 +97,7 @@ module.exports = {
                         loc: location,
                         messageId: "unexpected",
                         fix(fixer) {
-                            const finalEOLs = /(?:\r?\n)+$/,
+                            const finalEOLs = /(?:\r?\n)+$/u,
                                 match = finalEOLs.exec(sourceCode.text),
                                 start = match.index,
                                 end = sourceCode.text.length;

lib/rules/func-call-spacing.js

@@ -93,8 +93,8 @@ module.exports = {
                 return;
             }
 
-            const textBetweenTokens = text.slice(prevToken.range[1], parenToken.range[0]).replace(/\/\*.*?\*\//g, "");
-            const hasWhitespace = /\s/.test(textBetweenTokens);
+            const textBetweenTokens = text.slice(prevToken.range[1], parenToken.range[0]).replace(/\/\*.*?\*\//gu, "");
+            const hasWhitespace = /\s/u.test(textBetweenTokens);
             const hasNewline = hasWhitespace && astUtils.LINEBREAK_MATCHER.test(textBetweenTokens);
 
             /*

lib/rules/getter-return.js

@@ -14,7 +14,7 @@ const astUtils = require("../util/ast-utils");
 //------------------------------------------------------------------------------
 // Helpers
 //------------------------------------------------------------------------------
-const TARGET_NODE_TYPE = /^(?:Arrow)?FunctionExpression$/;
+const TARGET_NODE_TYPE = /^(?:Arrow)?FunctionExpression$/u;
 
 /**
  * Checks a given code path segment is reachable.

lib/rules/handle-callback-err.js

@@ -52,7 +52,7 @@ module.exports = {
          */
         function matchesConfiguredErrorName(name) {
             if (isPattern(errorArgument)) {
-                const regexp = new RegExp(errorArgument);
+                const regexp = new RegExp(errorArgument); // eslint-disable-line require-unicode-regexp
 
                 return regexp.test(name);
             }

lib/rules/id-match.js

@@ -53,7 +53,7 @@ module.exports = {
         // Options
         //--------------------------------------------------------------------------
         const pattern = context.options[0] || "^.+$",
-            regexp = new RegExp(pattern);
+            regexp = new RegExp(pattern); // eslint-disable-line require-unicode-regexp
 
         const options = context.options[1] || {},
             properties = !!options.properties,

lib/rules/indent-legacy.js

@@ -975,7 +975,7 @@ module.exports = {
          * @returns {boolean} the result
          */
         function isWrappedInParenthesis(node) {
-            const regex = /^return\s*?\(\s*?\);*?/;
+            const regex = /^return\s*?\(\s*?\);*?/u;
 
             const statementWithoutArgument = sourceCode.getText(node).replace(
                 sourceCode.getText(node.argument), ""

lib/rules/indent.js

@@ -442,7 +442,7 @@ class OffsetStorage {
                 const offset = (
                     offsetInfo.from &&
                     offsetInfo.from.loc.start.line === token.loc.start.line &&
-                    !/^\s*?\n/.test(token.value) &&
+                    !/^\s*?\n/u.test(token.value) &&
                     !offsetInfo.force
                 ) ? 0 : offsetInfo.offset * this._indentSize;
 
@@ -785,7 +785,7 @@ module.exports = {
          * or the total number of linebreaks if the string is all whitespace.
          */
         function countTrailingLinebreaks(string) {
-            const trailingWhitespace = string.match(/\s*$/)[0];
+            const trailingWhitespace = string.match(/\s*$/u)[0];
             const linebreakMatches = trailingWhitespace.match(astUtils.createGlobalLinebreakMatcher());
 
             return linebreakMatches === null ? 0 : linebreakMatches.length;

lib/rules/jsx-quotes.js

@@ -20,14 +20,14 @@ const QUOTE_SETTINGS = {
         quote: "\"",
         description: "singlequote",
         convert(str) {
-            return str.replace(/'/g, "\"");
+            return str.replace(/'/gu, "\"");
         }
     },
     "prefer-single": {
         quote: "'",
         description: "doublequote",
         convert(str) {
-            return str.replace(/"/g, "'");
+            return str.replace(/"/gu, "'");
         }
     }
 };

lib/rules/key-spacing.js

@@ -528,7 +528,7 @@ module.exports = {
          * @returns {Object} Whitespace before and after the property's colon.
          */
         function getPropertyWhitespace(property) {
-            const whitespace = /(\s*):(\s*)/.exec(sourceCode.getText().slice(
+            const whitespace = /(\s*):(\s*)/u.exec(sourceCode.getText().slice(
                 property.key.range[1], property.value.range[0]
             ));