Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: avoid creating invalid regex in no-warning-comments (fixes #11471) #11472

Merged
merged 1 commit into from Mar 5, 2019
Merged

Fix: avoid creating invalid regex in no-warning-comments (fixes #11471) #11472

merged 1 commit into from Mar 5, 2019

Commits on Mar 4, 2019

  1. Fix: avoid creating invalid regex in no-warning-comments (fixes #11471) 

    5018378 changed the codebase to use unicode regexes almost everywhere, with the exception of places where regexes are constructed from user input. However, two issues occurred to cause a bug:

* Due to an oversight, the regular expressions constructed in the `no-warning-comments` rule were changed to be unicode regexes even though those regexes were constructed from user input.
* The `no-warning-comments` rule dynamically creates regexes with unnecessary escape characters, and unnecessary escape characters are invalid in unicode regexes.

This commit fixes the first issue. The second issue isn't a problem on its own, but it will need to be fixed in order to implement #11423.
    @not-an-aardvark
    not-an-aardvark committed Mar 4, 2019
    Copy the full SHA
    ce7cd8d View commit details
    Browse the repository at this point in the history