New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New: extends in glob-based config (fixes #8813) #11554
Conversation
7b2200c
to
1d3e90d
Compare
I'm not sure why "commit-message" check failed 🤔 |
1d3e90d
to
b493ee1
Compare
I updated this PR and I believe ready for review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your review!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks! Just left one question.
(If I use GitHub review feature to bundle multiple replies, GitHub seems to show those duplicate. 😕 ) |
It looks like This is the line which sets eslint/lib/cli-engine/config-array-factory.js Line 485 in 00d2c5b
Example of the override:
which obviously can't match any files in the project. |
@gziolo Would you mind opening a new issue? Thanks! |
I think it's similar to #12032. I commented there. I wanted to do more research before jumping into creating a new issue :) |
What is the purpose of this pull request? (put an "X" next to item)
[X] Add something to the core: fixes #8813
What changes did you make? (Give an overview)
This PR adds support for
extends
and nestedoverrides
inoverrides
setting.Both nested
overrides
settings and theoverrides
settings in extended configs in aoverrides
item work similarly. Those settings will be applied only when both glob patterns of the parentoverrides
and the childoverrides
were matched.Is there anything you'd like reviewers to focus on?
Nothing in particular.