Fix: no-new-wrappers reports only wrappers

[mysticatea]

What is the purpose of this pull request? (put an "X" next to item)

[X] Bug fix

Tell us about your environment

• ESLint Version: 6.0.1
• Node Version: 12.2.0
• npm Version: 6.9.2

What parser (default, Babel-ESLint, etc.) are you using?

Default.

Please show your full configuration:
What did you do? Please include the actual source code causing the issue.

new Math
new JSON

> eslint test.js --no-eslintrc --no-ignore --rule "no-new-wrappers:error"

What did you expect to happen?

No errors because those are not wrappers.

What actually happened? Please include the actual, raw output from ESLint.

~\dev\eslint\test.js
  1:1  error  Do not use Math as a constructor  no-new-wrappers
  2:1  error  Do not use JSON as a constructor  no-new-wrappers

✖ 2 problems (2 errors, 0 warnings)

What changes did you make? (Give an overview)

This PR makes no-new-wrappers reporting only wrappers.

I guess that no-obj-calls rule is a more proper place to report it.

Is there anything you'd like reviewers to focus on?

Is this direction correct?

[mdjermanovic]

From the history it seems that Math and JSON were inherited from the removed no-ctor rule.

I'd be happy to prepare PR to check NewExpression nodes as well in no-obj-calls. This should catch only runtime errors as the rule checks the globals only since the last commit, so I guess it is acceptable for a semver-minor?

[ljharb]

they're not wrappers, but since those things are always objects and never functions, it's never code that should ship to production. Perhaps the replacement could merge before this fix?

[mdjermanovic]

Would be good to merge both at the same time, or maybe better have a single PR for both changes.

(of course, all this if it's acceptable for a semver-minor to have more warnings in no-obj-calls by default)

[platinumazure]

I think we need an RFC with more specific details to show the full design needed to solve this issue.

[kaicataldo]

How do we want to proceed here?

[nzakas]

I'd recommend we merge this PR and update no-obj-calls to cover Math and JSON.

[mdjermanovic]

I'd recommend we merge this PR and update no-obj-calls to cover Math and JSON.

PR #12909

[nzakas]

@mysticatea can you take a look at the merge conflicts on this?

[nzakas]

The commits in this PR have been included in #12909, so closing this one.