New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: reset to the default color #12174
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a way to test this change? (E.g., a unit test which changes something about chalk before calling the linter, and then we could check the output to make sure the file name does not have the changes?
I'm also wondering if it would make more sense to just call chalk.reset()
by itself earlier in the formatter, so we could have a comment and make clear what's going on?
I'm not strongly opposed to merging as is, but I just want to see if we could make some small improvements here. Thanks!
@platinumazure I agree, I just changed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
What is the purpose of this pull request? (put an "X" next to item)
[ ] Documentation update
[x] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofixing to a rule
[ ] Add a CLI option
[ ] Add something to the core
[ ] Other, please explain:
What changes did you make? (Give an overview)
When we issue a warning on webpack, every warning is yellow and bold.
With
eslint-loader
and thestylish
formatter the first line is different from the others.webpack-contrib/eslint-loader#292
Is there anything you'd like reviewers to focus on?