New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update: Report global Atomics calls in no-obj-calls (fixes #12234) #12258
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eslint-deprecated
bot
added
the
triage
An ESLint team member will look at this issue soon
label
Sep 11, 2019
There are 3 👍 but I'm not sure is the change in this form accepted for a semver-minor? |
mysticatea
added
accepted
There is consensus among the team that this change meets the criteria for inclusion
bug
ESLint is working incorrectly
enhancement
This change enhances an existing feature of ESLint
rule
Relates to ESLint's core rules
and removed
triage
An ESLint team member will look at this issue soon
labels
Sep 13, 2019
I'm fine with semver-minor (A bug fix in a rule that results in ESLint reporting more errors). Since it just reports runtime error code, I believe it's small risk. |
mysticatea
approved these changes
Sep 13, 2019
platinumazure
approved these changes
Sep 13, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
ilyavolodin
approved these changes
Sep 14, 2019
This was referenced Sep 24, 2019
This was referenced Oct 8, 2019
This was referenced Oct 22, 2019
This was referenced Nov 9, 2019
eslint-deprecated
bot
added
the
archived due to age
This issue has been archived; please open a new issue for any further discussion
label
Mar 13, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
accepted
There is consensus among the team that this change meets the criteria for inclusion
archived due to age
This issue has been archived; please open a new issue for any further discussion
bug
ESLint is working incorrectly
enhancement
This change enhances an existing feature of ESLint
rule
Relates to ESLint's core rules
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of this pull request? (put an "X" next to item)
[X] Bug fix
[X] Changes an existing rule #12234
This PR modifies the
no-obj-calls
to:Atomics()
as described in no-obj-calls should report Atomics() #12234, which can produce more errors by default.E.g., the rule will not report
Math()
if theMath
is shadowed or turnedoff
.Also, the rule will not report
Reflect()
if an ES2015+ environment is not activated (and the variable isn't added manually as a global in the config file or/*global*/
). The same applies toAtomics
and ES2017+ environment.What changes did you make? (Give an overview)
Added
Atomics
to the list of non-callable globals and modified the logic to report only references to defined global variables.Is there anything you'd like reviewers to focus on?